Allow full ticket ref syntax in the CommitTicketUpdater

[Lele Gaifax]

Currently it does not handle the full TracLinks syntax: ticket:10#comment:2.

Could something like ​this patch be applied?

[Ryan J Ollos]

I don't think it is intended that all forms of the ticket TracLinks be allowed as ticket reference tokens. Supporting the comment:2:ticket:10 TracLink form would appear to require difficult changes. However I think we can add support for the ticket:10#comment:2 form.

The ticket:10#comment:2 form works when referencing only a single ticket, which I don't think was intentional, but rather just a consequence of how the matching is implemented. The comment TracLink doesn't work correctly when multiple tickets are referenced, for example: ticket:10#comment:2 and ticket:11#comment2 - a reference to only the first ticket is inserted.

Proposed changes in log:rjollos.git:t11622.

[lelit]

I see, and find it reasonable: I did not even know about the alternative ordered syntax.

Looking at your patch, what does ticket:10#comment:description do? Trying it out in the SandBox, it seems it addresses the description field of the ticket… and I fail to see a concrete use case for it (in the CommitTicketUpdater context, I mean): I needed support for ticket:10#comment:2 in cases when a previous commit closed the ticket, then the QA people reopened it because the fix was not enough, annotating the reason, and one more commit was needed.

[Ryan J Ollos]

Replying to lelit:

I see, and find it reasonable: I did not even know about the alternative ordered syntax.

The syntaxes can be found at TracLinks#comment:links. It seems useful to align the syntaxes as much as possible.

[Ryan J Ollos]

Committed to trunk in [12825].