font is not valid in newer firefox versions

[wuker@…]

in

htdocs/common/css/trac.css

there is a section

/* Forms */
input, textarea, select { margin: 2px }

which is missing a ; and there should be added a font-size definition, otherwise the font has the system-default fontsize, which can be really huge at a retina display (Hi-Resolution displays)

so It should look like

/* Forms */
input, textarea, select {
 margin: 2px;
 font-size:13px;
}

[wuker@…]

Screenshot on a high resolution display

[Jun Omae]

/* Forms */
input, textarea, select { margin: 2px }

which is missing a ;

No. That is valid.

… and there should be added a font-size definition, otherwise the font has the system-default fontsize, which can be really huge at a retina display (Hi-Resolution displays)

Are you using which version of Firefox and Operating system?

Firefox respects font-family in system font settings for form widgets all along. However, I don't know whether font-size is respected or not.

refs ​http://mxr.mozilla.org/mozilla-central/source/layout/style/forms.css.

[anonymous]

I use Linux Ubuntu 14.04 with a global zoom factor of 2.0.

If i reset the zoom factor to default 1.0 everything looks fine, but only because then everything is really small.

If I set it to 2.0 only the input fields get resized by factor 2.0 but all other text in Trac isn't.

My suggested solution with font-size:13px; definitely defined fixes this issue for zoom factor 2 and has no negative effect on a normal zoom.

It seems like font: 13px Helvetia,... isn't supported anymore since Firefox 24 or so

[Jun Omae]

Thanks for feedback.

It would be good to apply the following. I don't think that font-size is needed for textarea because its initial value is medium on Firefox.

trac/htdocs/css/trac.css

@@ -68 +68 @@
 
 /* Forms */
 input, textarea, select { margin: 2px }
+input, select, button { font-family: inherit; font-size: 100% }
 /* Avoid to inherit white-space of its parent element for IE 11, #11376 */
 textarea { white-space: pre-wrap }
 input, select { vertical-align: middle }

[anonymous]

yes confirmed, you are right: font-size:100% seems to work fine as well, and textareas are not affected.

[Jun Omae]

Thanks. I also confirmed on fresh install of Ubuntu 14.04. Firefox on Windows 7 doesn't have the issue.

I'll apply the changes to 0.12-stable, 1.0-stable and trunk later.

[Jun Omae]

Fixed in [12769] and merged to [12770] and [12772].