The auto preview xhr request is sent on Firefox with IME active even if a user is inputting text

[t2y <tetsuya.morimoto@…>]

This issue is occurred on Firefox only with special state. Because, Firefox never fired the keydown or keypress event with ​IME active. I confirmed this is not reproduced on Chrome32 and IE8.

However, for IME user (Asian people only?), we are typing alphabetical character and mother language switching the IME mode. So, the auto preview xhr request is sent since it is not called clearTimeout during inputting own language.

It can be avoided to observe the input event for INPUT and TEXTAREA.

[t2y <tetsuya.morimoto@…>]

This is a patch to fix for 1.0-stable branch. Could you review it.

​https://github.com/t2y/trac/commit/a993e01048578ccb1079f365076b30851c4faadf

[t2y <tetsuya.morimoto@…>]

Oops! IE8 never fired the input event.

​http://stackoverflow.com/questions/2823733/textarea-onchange-detection ​http://stackoverflow.com/questions/11791855/how-to-detect-when-a-text-input-changes-with-ie8

[t2y <tetsuya.morimoto@…>]

I updated my patch by adding the propertychange event for IE8.

​https://github.com/t2y/trac/commit/5a1d31146711cd8193fbf1d35dc2e11f9db134ba

[Jun Omae]

It would be simple to add input event to detect editing using IMEs while auto-preview.

ref. ​https://developer.mozilla.org/en-US/docs/Web/Reference/Events/input.

trac/htdocs/js/auto_preview.js

@@ -92 +92 @@
     }
 
     var values = form.serializeArray();
-    return inputs.each(function() {
-      $(this).keydown(trigger).keypress(trigger).change(trigger).blur(trigger);
-    });
+    // use "input" event to detect editing using IMEs on Firefox (#11510)
+    return inputs.bind('input keydown keypress change blur', trigger);
   };
 
   // Enable automatic previewing to <textarea> elements.
@@ -150 +149 @@
         return true;
       }
 
-      $(this).keydown(trigger).keypress(trigger).blur(trigger);
+      // use "input" event to detect editing using IMEs on Firefox (#11510)
+      $(this).bind('input keydown keypress blur', trigger);
     });
   };
 })(jQuery);

[t2y <tetsuya.morimoto@…>]

Oh, it's quite simple! :) I tried jomae's patch and it works.

[Jun Omae]

Also cut and paste of context-menu lead the same issue on Internet Explorer 8 and 11. In Firefox and Chrome, the cut and paste raise "input" event.

I revised my patch. I think we should fix it in 0.12-stable.

trac/htdocs/js/auto_preview.js

@@ -92 +92 @@
     }
 
     var values = form.serializeArray();
-    return inputs.each(function() {
-      $(this).keydown(trigger).keypress(trigger).change(trigger).blur(trigger);
-    });
+    // See #11510
+    return inputs.bind('input cut paste keydown keypress change blur',
+                       trigger);
   };
 
   // Enable automatic previewing to <textarea> elements.
@@ -150 +150 @@
         return true;
       }
 
-      $(this).keydown(trigger).keypress(trigger).blur(trigger);
+      // "input" event to detect editing using IMEs on Firefox,
+      // "cut" and "paste" events to detect editing using context
+      // menu on Internet Explorer (#11510)
+      $(this).bind('input cut paste keydown keypress blur', trigger);
     });
   };
 })(jQuery);

[Jun Omae]

Fixed in [12560] and merged in [12561] and [12562]. Thanks for reporting and patch!

[t2y <tetsuya.morimoto@…>]

That's good to know. Thank you, too!