Hide batch modify form when there are no query results

[Ryan J Ollos]

The batch modify form is shown when there are no query results, however the Action fieldset is empty and the form can't serve any function.

The proposed change will hide the #batchmod_form when there are no query results.

trac/ticket/templates/query.html

@@ -223 +223 @@
       </form>
 
       <xi:include href="query_results.html" />
-      <xi:include py:if="batch_modify" href="batch_modify.html" />
+      <xi:include py:if="tickets and batch_modify" href="batch_modify.html" />
 
       <div id="trac-report-buttons" class="buttons"
            py:with="edit = report_resource and 'REPORT_MODIFY' in perm(report_resource);

[Ryan J Ollos]

I was hoping to write a functional test for this, but since we can't test JavaScript with Twill, and after #11014 the Batch Modification section is hidden when JavaScript is disabled, it doesn't seem to be possible.

Committed to 1.0-stable in [12245] and merged to trunk in [12246].

[Ryan J Ollos]

Proposed further refinement: only add the group toggle checkbox if there are entries in the table:

trac/htdocs/js/query.js

@@ -393 +393 @@
 
     // Add a checkbox at the top of the column
     // to select every ticket in the group.
-    $("table.listing tr th.id").each(function() {
-      $(this).before(
-        $('<th class="batchmod_selector sel">').append(
-          $('<input type="checkbox" name="batchmod_toggleGroup" />').attr({
-            title: _("Toggle selection of all tickets shown in this group")
-          })));
-    });
+    if ($("table.listing tr td.id").length) {
+        $("table.listing tr th.id").each(function() {
+          $(this).before(
+            $('<th class="batchmod_selector sel">').append(
+              $('<input type="checkbox" name="batchmod_toggleGroup" />').attr({
+                title: _("Toggle selection of all tickets shown in this group")
+              })));
+        });
+    }
 
     // Add the click behavior for the group toggle.
     $("input[name='batchmod_toggleGroup']").click(function() {

[Ryan J Ollos]

Patch in comment:2 committed to 1.0-stable in [12332] and merged to trunk in [12333].