The TracLinks [1,3:4] does not show the correct range of revisions

[Ryan J Ollos]

[2,4:5] and [2,4-5] are correct, however [1,4:5] and [1,4-5] show r1 and the range HEAD revision through rHEAD - n + 4, where n is the number from the preferences form Show at most n revisions per page.

[Jun Omae]

[1-2] has the same issue.

Proposed changes are the following patch and functional tests will be added later. Also, 0.12-stable have the same issue. I'll backport.

trac/versioncontrol/web_ui/log.py

@@ -147 +147 @@
                                 if rev != nrev: # no, we need a separator
                                     yield (np, nrev, None)
                             yield node_history[0]
-                        prevpath = node_history[-1][0] # follow copy
-                        b = repos.previous_rev(rev)
                         if len(node_history) > 1:
                             expected_next_item = node_history[-1]
+                            prevpath = expected_next_item[0]  # follow copy
+                            b = expected_next_item[1]
                         else:
                             expected_next_item = None
+                            break  # no more older revisions
                 if expected_next_item:
                     yield (expected_next_item[0], expected_next_item[1], None)
         else:

[Ryan J Ollos]

It looks good, thanks for fixing it! At least for the cases I tested, it looks like the break is the primary fix for the issue, and the other two changes are refactoring / optimization.

[Jun Omae]

Thanks for the feedback! log:jomae.git:ticket11346_0.12.6dev includes functional tests. I'll push it to 0.12-stable branch and merge into 1.0-stable and trunk.

[Jun Omae]

Committed it to 0.12-stable in [12220] and merged to 1.0-stable and trunk in [12221,12222].