Wrong `NullTranslations` class in functional tests

[osimons]

It seems that my derived use of functional test infrastructure in plugins now fails when testing against 1.0/trunk:

File "trac/util/translation.py", line 153, in activate
    t.add(Translations.load(locale_dir, locale or 'en_US',
AttributeError: 'NullTranslations' object has no attribute 'add'

What seems to be the case is that t.__class__ is NullTranslations is False as the previously imported gettext.NullTranslations does not resolve as equal to the actual babel.support.NullTranslations of the t variable. However, if I run tests without Babel installed it all works fine.

Hmm. Seems this follows from recent Babel 1.0dev changes, most specifically babel:changeset:650 I guess. Reverting to Babel 0.9.6 seems to solve the issue. However, the issue does not appear when testing against latest 0.12-stable so I guess it may also be connected to some other recent changes in for 1.0dev and later.

Here is a suggestion that should perhaps catch all variants:

trac/util/translation.py

@@ -146 +146 @@
                 self._activate_failed = True
                 return
             t = Translations.load(locale_dir, locale or 'en_US')
-            if not t or t.__class__ is NullTranslations:
+            if not t or 'NullTranslations' in t.__class__.__name__:
                 t = self._null_translations
             else:
                 t.add(Translations.load(locale_dir, locale or 'en_US',

[Christian Boos]

So this would fix #10882 as well?

[osimons]

Ah, hadn't actually tested with the Trac tests - I was only running my plugin tests. Didn't know it was a problem in Trac too.

But yes, Trac trunk tests runs fine too with patch applied.

[Christian Boos]

And without? I actually haven't verified that some Trac tests are failing with Babel 1.0dev (#10882 was an error within the web interface).

[osimons]

Tests fails without the patch.

Quickly skimming the Babel code I see that babel.support.NullTranslations is supposed to be a subclass of gettext.NullTranslations so there may well be more reliable ways of testing then just checking for the name NullTranslations. Using isinstance() is likely better and works too:

trac/util/translation.py

@@ -146 +146 @@
                 self._activate_failed = True
                 return
             t = Translations.load(locale_dir, locale or 'en_US')
-            if not t or t.__class__ is NullTranslations:
+            if not t or isinstance(t, NullTranslations):
                 t = self._null_translations
             else:
                 t.add(Translations.load(locale_dir, locale or 'en_US',

[Jun Omae]

I've tried the patch in comment:4, however, Trac cannot translate messages with the patch. Because babel.support.Translations class on babel trunk is a subclass of babel.support.NullTranslations.

I think that the following would be simple and better.

trac/util/translation.py

@@ -146 +146 @@
                 self._activate_failed = True
                 return
             t = Translations.load(locale_dir, locale or 'en_US')
-            if not t or t.__class__ is NullTranslations:
+            if not isinstance(t, Translations):
                 t = self._null_translations
             else:
                 t.add(Translations.load(locale_dir, locale or 'en_US',

[osimons]

LGTM: +1

[Christian Boos]

#10882 and #10903 were closed as duplicates.

[Christian Boos]

Jun, do you mind taking this one over? (applying your patch from comment:5)

I verified that with this patch and Babel 1.0dev (babel:changeset:fad20cd945e8/mirror) our tests pass. They also still pass with Babel 0.9.6 and without Babel.

[Jun Omae]

Oh, yes. I just work on it!

This issue occurs when compiled catalog file is missing for the locale, introduced in babel:r651.

$ find trac/locale -name '*.mo' -exec /bin/rm -- '{}' +  # Remove all *.mo files
$ make python=25-babel1.0 clean Trac.egg-info unit-test
find -name \*.py[co] -exec rm {} \;
rm -f .figleaf* *.figleaf
...
  File "/home/jun66j5/src/trac/edgewall/svn/branches/1.0-stable/trac/util/translation.py", line 152, in activate
    t.add(Translations.load(locale_dir, locale or 'en_US',
AttributeError: 'NullTranslations' object has no attribute 'add'
make: *** [unit-test] Error 1

Verified my patch with our tests:

• Babel 1.0dev-r661 with compiled catalogs and without catalogs
• Babel 0.9.6 with compiled catalogs and without catalogs
• Babel is not installed

Committed in [11783].

[anonymous]

Thanks, the patch fix my problem.

Have a good day