`babel.Translations.load({...}).install()` from a plugin breaks the loaded translations catalog

[Jun Omae]

generate_messages_js command of setuptools works for Trac and Trac plugins. The command generates "messages file for javascript" as the following;

// Generated messages javascript file from compiled MO file
babel.Translations.load({"domain":"{plugin-name}-js",...}).install();

The babel.Translations.install() installs _, genetext and ngettext functions binded the loaded translations instance to window instance.

When a plugin loads the messages catalog for javascript, Therefore, it overwrites the last installed functions (maybe from trac/htdocs/messages/*.js) and messages for Trac will not be translated.

Related branches

• repos:jomae.git:ticket10749/babeljs-multi-domain

[Christian Boos]

Looks sound. Unfortunately, I don't have a quick way to try this by myself, so feel free to apply.

[Jun Omae]

Replying to cboos:

Looks sound. Unfortunately, I don't have a quick way to try this by myself, so feel free to apply.

Applied in [11101]. Thanks.

[Ryan J Ollos <ryano@…>]

Strange that the heading for comment:1 is shown even though Comments only is selected. Even more strange is that I can't reproduce this behavior in a dev instance of r11100, or on the demo site, which is at r11050.

[Peter Suter]

I think comment:1 contains a newline, so it isn't considered empty. (Reproduce it on the ​demo-0.13 site by pressing the Enter key in the comment field before submitting.)

[Remy Blank]

We could strip the comment when checking if it's empty.

[Ryan J Ollos <ryano@…>]

Replying to rblank:

We could strip the comment when checking if it's empty.

The behavior seems closely related to the patch in #10748, so I'll add to my todo list to handle this case as part of that patch as well.

[Ryan J Ollos <ryano@…>]

Replying to Ryan J Ollos <ryano@…>:

The behavior seems closely related to the patch in #10748, so I'll add to my todo list to handle this case as part of that patch as well.

Issue has been addressed in the following patch ticket:10748:t10748-r11103-1.patch​