move svn support to tracopt

[Christian Boos]

We currently have our support for Subversion directly below trac.versioncontrol​. Now that we have integrated Git support in trunk/tracopt/versioncontrol/git, it would be fair to also move svn_fs.py​ and svn_prop.py​ in trunk/tracopt/versioncontrol/svn.

OTOH, svn_authz.py​ doesn't have any Subversion specific dependency in it, and could theoretically be used to impose a Subversion-like fine-grained permission model on other kind of repositories, so there's no reason to move it.

[Remy Blank]

Modules moved in [11082]. The stub modules left in the original location provide all the same content as the original module, so hopefully we're not breaking anything with this (except for requiring SVN support to be explicitly enabled in trac.ini, of course).

Strangely, this has increased the run time of the full test suite by about 10 seconds on my machine. My guess is that this is due to enabling all of tracopt.* in the test suite, but I wasn't able to confirm this hypothesis.

[Remy Blank]

Confirmed, enabling tracopt.* for all unit and functional tests (in test.py and testenv.py) adds 9 seconds to the test suite (and more importantly, it's independent of the move of svn_fs and svn_prop to tracopt, which is what I was interested in).

Enabling only tracopt.versioncontrol.svn.* leads to no increase at all. Committed in [11083].

[buhrt@…]

Having spent 5-6+hr fighting the error: Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": Can't find an appropriate component, maybe the corresponding plugin was not enabled? ). Look in the Trac log for more information.

and determining [11081] was the cause, with the help of 'osimons' we determined at least wiki:TracSubversion#Troubleshooting and wiki:TracUpgrade need to be changed and corrected.

The proper options are at tracopt.versioncontrol.svn.* (not trac.versioncontrol.svn_*) Also a hint that when upgrading from 0.13dev to 1.0 svn will not be available by default anymore and must be manually enabled otherwise a user will see the error above. (Even if upgrading from [11080] using a perfectly fine Trac).

My original notes I logged in the Google group are at: ​​http://www.aftinc.net/misc/trac-bug.txt

[Remy Blank]

Replying to buhrt@…:

Also a hint that when upgrading from 0.13dev to 1.0 svn will not be available by default anymore and must be manually enabled otherwise a user will see the error above. (Even if upgrading from [11080] using a perfectly fine Trac).

Yes, the release notes aren't done yet, mainly because… well, we haven't released yet :)

and determining [11081] was the cause, with the help of 'osimons' we determined at least wiki:TracSubversion#Troubleshooting and wiki:TracUpgrade need to be changed and corrected.

Would you mind making the necessary changes? This is a wiki open to everyone for editing, and it would greatly help us if you could add the notes that would have helped you for other users. Thanks!

[buhrt@…]

I also put a reference in wiki:TracUpgrade, wiki:TracSubversion, I also think wiki:TracIni#components-section needs some explaination also about tracopt.* and possibly a section for tracopt.versioncontrol.svn.* possibly.

[Remy Blank]

Thanks!

[Ryan J Ollos]

Replying to cboos:

OTOH, svn_authz.py​ doesn't have any Subversion specific dependency in it, and could theoretically be used to impose a Subversion-like fine-grained permission model on other kind of repositories, so there's no reason to move it.

Would it make sense to move the svn_authz.py permissions policy to tracopt.perm?