Modify ↓
#10607 closed defect (fixed)
GitPlugin: Don't use Popen terminate()
Reported by: | Peter Suter | Owned by: | Peter Suter |
---|---|---|---|
Priority: | normal | Milestone: | 1.0 |
Component: | plugin/git | Version: | |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: |
Properly terminate git subprocesses (fix Python 2.5 incompatibilities and Windows specific issues) |
||
API Changes: | |||
Internal Changes: |
Description
Created as part of the move of GitPlugin. Tickets originally reported for th:GitPlugin: th:#9560, th:#9581, #9646
Replying to sjtoik:
popen.terminate have been introduced in python 2.6
Replying to Greg:
It seems that calling
p[0].terminate()
(on lines 744 and 760 of PyGIT.py) will fail with the access is denied message on Windows
Attachments (0)
Change History (4)
comment:1 by , 13 years ago
comment:2 by , 13 years ago
Milestone: | → 0.13 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
comment:3 by , 13 years ago
Owner: | set to |
---|
comment:4 by , 12 years ago
Release Notes: | modified (diff) |
---|
Note:
See TracTickets
for help on using tickets.
[11000] replaces
subprocess.Popen.terminate()
(which is only available since Python 2.6) with a quite ugly mix ofwin32api.TerminateProcess
on Windows andos.kill()
elsewhere.I still get the access is denied errors on Windows, so I added a
try: ... except: ...
for that.Any better ideas?