Edgewall Software
Modify ↓

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#10324 closed defect (fixed)

trac-mercurial - python 2.4 compatibility

Reported by: guidod-2007-@… Owned by: guidod-2007-@…
Priority: normal Milestone: plugin - mercurial
Component: plugin/mercurial Version: 0.12dev
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

A package build for CentOs-5 with its Python 2.4 revealed that a single line in Trac-Mercurial uses the expression if-else that is not compatible. In this case it can be replaced by some and-or expression. 

--- tracext/hg/hooks.py.orig    2011-08-20 00:00:01.000000000 +0200
+++ tracext/hg/hooks.py 2011-08-20 00:00:40.000000000 +0200
@@ -104 +104 @@
-            revs_per_call = 160 if os.name == 'nt' else 1000
+            revs_per_call = (os.name == 'nt' and 160 or 1000)

Attachments (0)

Change History (3)

comment:1 by Remy Blank, 13 years ago

Milestone: 0.12.3 → plugin - mercurial
Owner: set to Remy Blank

Yes, that was my fault. Good catch!

comment:2 by Remy Blank, 13 years ago

Resolution: → fixed
Status: new → closed

Patch applied in [10784]. Thanks!

comment:3 by Remy Blank, 13 years ago

Owner: changed from Remy Blank to guidod-2007-@…

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain guidod-2007-@….
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from guidod-2007-@… to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.