Context Navigation

Modify ↓

#10261 closed defect (fixed)

FilterSystem.test: retval not initialized

Reported by:	Jakub Wilk <jwilk@…>	Owned by:	Dirk Stöcker
Priority:	normal	Milestone:	plugin - spam-filter
Component:	plugin/spamfilter	Version:	0.12dev
Severity:	normal	Keywords:
Cc:		Branch:
Release Notes:
API Changes:
Internal Changes:

Description

In FilterSystem.test, in the for strategy in self.strategies loop, the retval variable is not always initialized. For example, if self.use_external is set to false, this code will explode with NameError. Worse still, in some circumstances, retval set in one interation could be reused in another one.

Attachments (0)

Change History (2)

comment:1 by Dirk Stöcker, 13 years ago

Resolution:	→ fixed
Status:	new → closed

Fixed in r10756.

comment:2 by Ryan J Ollos, 10 years ago

Milestone:	→ plugin - spam-filter

Modify Ticket

Change Properties

Summary:
Description:	In {{{FilterSystem.test}}}, in the {{{for strategy in self.strategies}}} loop, the {{{retval}}} variable is not always initialized. For example, if {{{self.use_external}}} is set to false, this code will explode with {{{NameError}}}. Worse still, in some circumstances, {{{retval}}} set in one interation could be reused in another one. You may use WikiFormatting here.
Type:		Priority:
Milestone:		Component:
Version:		Severity:
Keywords:		Cc:	Set your email in Preferences
Branch:
Release Notes:
API Changes:
Internal Changes:

Action

leave as closed The owner will remain Dirk Stöcker.

reopen The resolution will be deleted. Next status will be 'reopened'.

change ownership to The owner will be changed from Dirk Stöcker to the specified user.

Add Comment

Your email or username:

E-mail address and name can be saved in the Preferences .

You may use WikiFormatting here.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.

Download in other formats: