Upgrade to jQuery 1.7.x

[Christian Boos]

​http://blog.jquery.com/2011/05/03/jquery-16-released/

Shouldn't be a big deal, but as usual with a new major version, careful testing is needed (and early exposure in trunk could bring that).

Also the .prop(), .removeProp(), and .attr() section there made me think of our little discussion about .checked in threaded comments(ticket:7145#comment:28). We should experiment.

[Anton]

By the way:

this ticket should be upgrade to jQuery 1.7.x or whatever is actual at the release date.

I just changed the title to 1.7.x Actually the 1.7.2 beta is out: ​http://blog.jquery.com/2012/01/31/jquery-1-7-2-beta-1-released/

[Christian Boos]

Upgraded to 1.7.2 in r11035.

I didn't notice any regression in Chrome yet, but there's one in IE (7 and 8 but not 9): for the semi-automatic bug report, the newlines are missing in the description, so the structure in the wiki text is lost.

[Christian Boos]

Replying to cboos:

in IE (7 and 8 but not 9): for the semi-automatic bug report, the newlines are missing in the description, so the structure in the wiki text is lost.

The following works:

trac/templates/error.html

@@ -46 +46 @@
     <script type="text/javascript">/*<![CDATA[*/
       jQuery(document).ready(function($) {
         $("form.newticket textarea").each(function() {
-          $(this).text($(this).text()
+          $(this).text($(this).html().replace(/\r/g, '')
                          .replace(/#USER_AGENT#/m, navigator.userAgent)
                          .replace(/#JQUERY#/m, $().jquery));
         });

However, looking at the jQuery code, it seems that the code which removed the newlines is no longer present in 1.7.3pre (referring to ​http://bugs.jquery.com/ticket/11153 instead).

So maybe the best course of action for this little issue is to simply wait for the next upgrade, 1.7.3.

[Jun Omae]

Replying to cboos:

Replying to cboos:

in IE (7 and 8 but not 9): for the semi-automatic bug report, the newlines are missing in the description, so the structure in the wiki text is lost.

The following works: #!diff...

I wonder we don't use .val() instead of .text()…. It works on Firefox 11, Chrome 19 and IE 8.

trac/templates/error.html

@@ -46 +46 @@
     <script type="text/javascript">/*<![CDATA[*/
       jQuery(document).ready(function($) {
         $("form.newticket textarea").each(function() {
-          $(this).text($(this).text()
-                         .replace(/#USER_AGENT#/m, navigator.userAgent)
-                         .replace(/#JQUERY#/m, $().jquery));
+          $(this).val($(this).val()
+                      .replace(/#USER_AGENT#/m, navigator.userAgent)
+                      .replace(/#JQUERY#/m, $().jquery));
         });
       });
     /*]]>*/</script>

[Christian Boos]

Replying to jomae:

I wonder we don't use .val() instead of .text()…. It works on Firefox 11, Chrome 19 and IE 8.

… and indeed doesn't need the .replace(/\r/g, '') trick!

I overlooked .val() in the jQuery API. It seems totally appropriate to use it here. Please commit!

[Jun Omae]

Replying to cboos:

… and indeed doesn't need the .replace(/\r/g, '') trick!

I overlooked .val() in the jQuery API. It seems totally appropriate to use it here. Please commit!

Ok, committed in [11037].

[Christian Boos]

I just noticed we were still running r11033 on t.e.o (i.e. with jQuery 1.5.1). Let's get a bit more exposure before closing this ticket (reassigning to jun, as he's to one having contributed the significant fix on this topic).

[Remy Blank]

We have been running [11050] (jQuery 1.7.2 as on trunk) since June 3rd, and haven't noticed any regressions.