Edgewall Software

Changes between Version 19 and Version 20 of WikiRename


Ignore:
Timestamp:
Feb 16, 2011, 3:14:30 PM (9 years ago)
Author:
mitar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • WikiRename

    v19 v20  
    5656    - Before re-inventing the wheel again a hint to look at [th:wiki:WikiRenamePlugin WikiRenamePlugin], this is done here: http://trac-hacks.org/browser/wikirenameplugin/0.11/wikirename/util.py#L76
    5757      * cboos: well, that's rather an example of how to '''not''' implement this. To do it correctly, the wiki parser has to provide some direct support for this (#4431, with an eye on keeping enough information in the syntax nodes for being able to modify the original text in place, or alternatively have a ''wiki source'' formatter that can be specialized)
     58        * mitar: but it works, quite well ;-)
    5859
    5960 * More robust error handling: what happens if a reparent fails mid-way (e.g. permission issue for one attachment)? The whole transaction is rolled back, but some attachment ''files'' could have been moved already. Should we try to move them back? Should we warn the user about what already got moved? After fixing the permission issue, a new rename should work, which might not be the case if the attachment table and the files are not in sync.