Version 2 (modified by 17 years ago) ( diff ) | ,
---|
Theme Plugins
This proposal describes a way trac could get a working theme support. The main idea is that every project which uses trac should have it's own theme. Or at least each major trac installation.
The current way is overriding htdocs_location
in the trac config to bypass the shipped css and js files and inject new ones. Using the site.html
file (talking of trac 0.11) you can then override the way the template is rendered. Because of the great Genshi API with XPATH support nearly everything is overrideable. But trac upgrades are a pain in the ass and distributing themes does not work.
Generic CSS Classes
One of the first things which should be done is cleaning up the shipped css files. They should use more generic classes and documented classes. Each plugin developer should be able to use them too in his plugins.
Also the trac core would only ship layout css files without color definitions. The default theme would then add the color definitions for the elements (links, browser etc). Currently the only way to change the trac colors is copying the default css files and replace all the color hex values with own ones.
To create a list of generic classes an analysis of the current css files and genshi templates would be required.
A CSS Preprocessor
CSS does not allow variables and constants unfortunately. Because of that a CSS preprocessor is the only way to use a value twice in a file. If a request in a chrome folder goes to foo.css
and the foo.css
file does not exist the chrome system would look for a foo.css.tmpl
. If that file exists trac loads it as python text template (string.Template
) and executes it.
Such a template would have access to the current theme provider described below.
cmlenz is not happy with this solution because it breaks static file serving over apache. Maybe there are better ways.
A Theme Provider
The most important part of a theme would be the theme provider. Because trac supports plugins which can add their own css files it's pretty hard to keep a global style without overriding the css files of the plugins too.
class IThemeProvider(Interface): def get_theme_color(name): """ Return the hexadecimal value for a given name. The actual color names should be specified on a wiki page in the trac.edgewall.org wiki so that plugin developers could get informations about the allowed colors. If a name is not overriden by the theme it has to return a default color. (for example ``#000000``) """
site.html
At the moment trac instances have a htdocs/
and a template/
folder. Both will stay, but the site.html
in the template folder goes.
The site.html
file will be part of a theme. If a theme implements not only the IThemeProvider
but also the ITemplateProvider
it can add a htdocs
and template
folder to the searchpath. In the latter would now be the site.html
file.
As long as the layout.html
file does not change you can override nearly everything in the site.html
file by using XPATH:
<html xmlns="http://www.w3.org/1999/xhtml" xmlns:py="http://genshi.edgewall.org/" xmlns:xi="http://www.w3.org/2001/XInclude" py:strip=""> <head py:match="head"> <!-- load the default header stuff including the layout and plugin css files --> ${select('*')} <!-- load own css files. not sure if get_css_url would be possible, maybe use the env stuff --> <link rel="stylesheet" href="${theme.get_css_url('style.css')}" /> <link rel="stylesheet" href="${theme.get_css_url('print.css')}" media="print" /> </head> <body py:match="body"> <!-- here a very complex example --> <div id="project-content"> <div id="project-header"> <h1>Project Trac</h1> </div> <div id="project-sidebar"> <!-- combine all three navigation bars into one --> <ul><li><ul> <!-- include main navigation --> ${select('div[@id="mainnav"]/ul/*')} <li><a href="http://www.example.org/">Project Webpage</a></ul></li> <li>User<ul> ${select('div[@id="metanav"]/ul/*')} </ul></li> <!-- this is a bit hackish, there should be a nicer way for it --> <li py:if="unicode(select('div[@id=\'main\']/div[@id=\'ctxtnav\']/ul/*'))"> Actions<ul> ${select('div[@id="main"]/div[@id="ctxtnav"]/ul/*')} </ul></li> <li>Search ${select('div[@id="banner"]/form[@id="search"]')} </li> </ul> </div> <div id="project-body"> <!-- include trac body output --> ${select('div[@id="main"]/*[@id!="ctxtnav"]')} </div> <div id="project-footer"> <a href="http://www.example.org/">Project</a> is open source software licensed under the <a href="http://www.gnu.org/copyleft/gpl.html">GPL</a>, development page powered by <a href="http://trac.edgewall.org/">Trac</a>. </div> </div> </body> </html>
That of course requires that the layout.html
and css classes/ids don't change after a trac update.
Attachments (3)
-
theming.patch
(25.7 KB
) - added by 17 years ago.
first patch
-
theming.2.patch
(28.4 KB
) - added by 17 years ago.
added missing file
-
theming.3.patch
(72.9 KB
) - added by 17 years ago.
another version of the patch, this time with "TracTheme", "JinjaTheme" and "CustomTheme". Not all areas are themed since i truncated all css files before in order to clean them up
Download all attachments as: .zip