Edgewall Software

Changes between Initial Version and Version 1 of Ticket #9990, comment 18


Ignore:
Timestamp:
Jan 31, 2011, 1:36:39 AM (13 years ago)
Author:
Remy Blank

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #9990, comment 18

    initial v1  
    33  Fix [http://bugs.python.org/issue8280 Issue8280] - urllib2's Request method will remove fragements in the url. This is how it is supposed to work, wget and curl do the same. Previous behavior was wrong.
    44
    5 It seems like we should remove the fragment when we verify the current URL.
     5It seems like we should remove the fragment when we verify the current URL:
     6{{{#!diff
     7diff --git a/trac/tests/functional/tester.py b/trac/tests/functional/tester.py
     8--- a/trac/tests/functional/tester.py
     9+++ b/trac/tests/functional/tester.py
     10@@ -147,7 +147,9 @@ class FunctionalTester(object):
     11         tc.formvalue('propertyform', 'comment', comment)
     12         tc.submit("submit")
     13         # Verify we're where we're supposed to be.
     14-        tc.url(self.url + '/ticket/%s#comment:.*' % ticketid)
     15+        # The fragment is present up to 2.7, see:
     16+        # http://trac.edgewall.org/ticket/9990#comment:18
     17+        tc.url(self.url + '/ticket/%s(?:#comment:.*)?$' % ticketid)
     18         return comment
     19 
     20     def attach_file_to_ticket(self, ticketid, data=None, tempfilename=None,
     21}}}
     22With this fix, all tests pass on 2.7.1 as well.