Edgewall Software

Changes between Initial Version and Version 1 of Ticket #9967, comment 3


Ignore:
Timestamp:
Sep 1, 2017, 4:51:32 PM (5 years ago)
Author:
Ryan J Ollos

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9967, comment 3

    initial v1  
    1 It might be good to move code into the setter, such as: [browser:tags/trac-1.3.2/trac/admin/web_ui.py@:269-273,279-282#L244 LoggingAdminPanel.render_admin_panel].
     1It might be good to delegate to the setter code that checks valid values, such as: [browser:tags/trac-1.3.2/trac/admin/web_ui.py@:269-273,279-282#L244 LoggingAdminPanel.render_admin_panel].
    22
    33Related, it would be nice if TracAdmin `config set` raised an error when setting an invalid value, at least for options defined in `ExtensionOption` and `OrderedExtensionOption`. Similarly, when enabling/disabling components with TracAdmin, we autocomplete the components: