[PATCH] milestone groups do not adhere to 'overall_completion = False'

[Andrew C Martin <andrew.c.martin@…>]

As I hinted at in #9718, milestone groups defined in TracIni do not adhere to 'overall_completion = False'. roadmap.py wraps the value of this field in a bool(), which always returns True for a non-empty string.

I have written attachment:overall_completion.patch​ which I believe corrects this issue.

Reproducible by adding these lines to your trac.ini:

[milestone-groups]
closed = closed
closed.order = 0
closed.overall_completion = true
new = new
new.order = 1
new.css_class = new
new.label = new
new.overall_completion = false
active = *
active.order = 2
active.css_class = open
active.label = in progress

Then observe that 'new' tickets don't count towards your completion total.

This is an issue in the current trunk, and I can confirm it existed as of the 0.11.6 branch.