`WikiPage` doesn't need the `ipnr` attribute

[Martin Scharrer <martin@…>]

Just saw this while changing ​th:WatchlistPlugin from own SQL code to the trac.wiki.model.WikiPage class:

Instances of the WikiPage class do not provide the ipnr as attribute as for all other wiki page values (version, author, etc.). In fact the _fetch method doesn't read this value from the DB.

If this is not by intention this should be fixed for consistency. Some plug-ins probably like to read this information out, e.g. I would have given the users the option to show it in their watchlist.

I would be willing to provide a patch.

[Christian Boos]

Well, why do you need the ipnr? I always thought nobody was actually interested in that and thought that we should even remove it in later releases.

[Remy Blank]

We removed the display of that information some time ago in 0.11-stable IIRC.

[Martin Scharrer <martin@…>]

Replying to cboos:

Well, why do you need the ipnr? I always thought nobody was actually interested in that and thought that we should even remove it in later releases.

As I said, I'm writing a plugin which shows the wiki data to the user as a table and I just wanted to be as comprehensive as possible. If you think about this that way I will just drop it. It's not an important thing for the plugin.

[Christian Boos]

All clear then. Let's remember to remove the ipnr information from the wiki table, at some later point.

[Thijs Triemstra]

Replying to cboos:

All clear then. Let's remember to remove the ipnr information from the wiki table, at some later point.

What version do you have in mind?

[Christian Boos]

0.14 of course. I don't think we should do any more schema change at this point for 0.13, as we should slowly try to finalize this version.

[Ryan J Ollos]

I was thinking we should add some notices to the documentation about the pending removal: log:rjollos.git:t9612-schedule-ipnr-removal.

[Ryan J Ollos]

Changes from comment:8 committed to 1.0-stable in [13512], merged to trunk in [13513].

[Ryan J Ollos]

Should we also remove ipnr from the Attachment class?

[Jun Omae]

Should we also remove ipnr from the Attachment class?

Yeah. We should consistently remove attachment.ipnr if wiki.ipnr will be removed.

[Ryan J Ollos]

Thanks. I'll add notices to attachment module about deprecation of ipnr and pending removal, as in comment:8. Changing milestone since work will be done in milestone:1.3.1.

[Jun Omae]

Related question, should we also remove [trac] show_ip_addresses option in 1.3.1?

[Ryan J Ollos]

Yeah, it looks like that should be removed. The only uses I see aside from adding the value to the Chrome data dictionary are:

• tags/trac-1.0.3/trac/templates/diff_view.html@:65#L65​
• tags/trac-1.0.3/trac/templates/history_view.html@:58#L58​

Side note: I didn't realize it was possible to link to a specific option and highlight it. I guess that works with any wiki word or phrase though. Very cool!

[Ryan J Ollos]

Deprecated ipnr attribute of attachment class in [13729:13730]. Deprecated show_ip_addresses in [13731:13732].

[carstenklein@…]

What about a hacked trac and where people upload unwanted attachments or alter wiki pages in ways we cannot imagine? Wouldn't it be nice to at least have the ip address from where the alteration or malicious upload came from?

[Ryan J Ollos]

For a publicly-accessible site, you probably want to be running SpamFilter. See also #12398.

For the specific case in which a site was hacked and you want to know the IP address, there are probably better ways to obtain that information such as logging from the web server.

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t9612.

[Christian Boos]

LGTM, + 2 remarks:

• we should also remove show_ip_addresses in chrome.py
• db42.py makes me think we could start to introduce a DDL helper functions, like upgrade_table(old_Table, new_Table) and a Table.remove_columns that would create a new Table instance, so that one could write upgrade_table(attachment_table.remove_columns('ipnr'), attachment_table)

[Ryan J Ollos]

Replying to Christian Boos:

• we should also remove show_ip_addresses in chrome.py

show_ip_addresses was removed in r14909. That change should probably have been committed with these changes.

• db42.py makes me think we could start to introduce a DDL helper functions, like upgrade_table(old_Table, new_Table) and a Table.remove_columns that would create a new Table instance, so that one could write upgrade_table(attachment_table.remove_columns('ipnr'), attachment_table)

Similar aim in #11872. I'll look into it.

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t9612.2. Some of the changes will be committed to 1.2-stable to address #11872.

[Jun Omae]

I think the upgrade_tables method should call update_sequence if the table has an auto increment primary key.

[Ryan J Ollos]

Replying to Jun Omae:

I think the upgrade_tables method should call update_sequence if the table has an auto increment primary key.

Is this only needed if the column with auto_increment has changed, or has been removed? If the column with auto_increment has not changed, then that column will have the same data in the new table as in the old.

[Jun Omae]

Replying to Ryan J Ollos:

Replying to Jun Omae:

I think the upgrade_tables method should call update_sequence if the table has an auto increment primary key.

Is this only needed if the column with auto_increment has changed, or has been removed? If the column with auto_increment has not changed, then that column will have the same data in the new table as in the old.

The upgrade_tables re-create tables. Auto-increment column uses sequence object in PostgreSQL. Then, the sequence object would be re-created and started with 1. Inserting old records wouldn't change the sequence.

See also #8575.

[Ryan J Ollos]

[7ea7e2d5/rjollos.git] calls update_sequence. I'll propose additional changes after #11872 is implemented.

[Ryan J Ollos]

Fix for Cannot operate on closed database error committed to 1.0-stable in r15018, merged to 1.2-stable in r15019, merged to trunk in r15020.

DatabaseManager.upgrade_tables committed to 1.2-stable in r15021,r15023, merged to trunk in r15022,r15024.