Edgewall Software
Modify

Opened 10 years ago

Closed 10 years ago

Last modified 6 years ago

#9604 closed enhancement (fixed)

New layout for the report list

Reported by: Christian Boos Owned by: Christian Boos
Priority: normal Milestone: 1.0
Component: report system Version: 0.13dev
Severity: normal Keywords: layout
Cc: hoff.st@…, ryan.j.ollos@… Branch:
Release Notes:

Reports: nicer looking list of reports, with direct link for going back to last query

API Changes:
Internal Changes:

Description

The report list is currently reusing a table listing for displaying the available reports. I tried to make this a bit prettier.

Snapshot and patch follows.

Show the proposed new layout, notice the sort links on the upper right corner.

Attachments (8)

new_report_list.png (33.5 KB ) - added by Christian Boos 10 years ago.
Show the proposed new layout, notice the sort links on the upper right corner.
new_report_list-r10049.patch (6.3 KB ) - added by Christian Boos 10 years ago.
Corresponding patch
new_report_list-2.png (20.1 KB ) - added by Christian Boos 10 years ago.
Show custom query links first, and descriptions hidden by default
custom-query-link.patch (3.9 KB ) - added by Christian Boos 10 years ago.
add a link to the last query and to a new custom query at the top of the list of reports. Applies on new_report_list-r10049.patch
clear-saved-query.patch (2.4 KB ) - added by Christian Boos 10 years ago.
add the possibility to clear the last saved query, from the report list. Applies on custom-query-link.patch
report-toggle-description.patch (3.5 KB ) - added by Christian Boos 10 years ago.
add a Show Descriptions toggle for the report list, defaults off. Applies on clear-saved-query.patch
new_report_list-3-default.png (13.3 KB ) - added by Christian Boos 10 years ago.
Descriptions folded
new_report_list-3-expanded.png (25.1 KB ) - added by Christian Boos 10 years ago.
Descriptions expanded

Download all attachments as: .zip

Change History (32)

by Christian Boos, 10 years ago

Attachment: new_report_list.png added

Show the proposed new layout, notice the sort links on the upper right corner.

by Christian Boos, 10 years ago

Corresponding patch

comment:1 by Christian Boos, 10 years ago

The snapshot shows a half translated French interface, but you get the idea…

Feedback welcomed.

comment:2 by Remy Blank, 10 years ago

Nice! Is the full report description shown below the title? That may be tricky for very long descriptions, but this case shouldn't be too frequent either.

comment:3 by Christian Boos, 10 years ago

You're right about long descriptions, my idea was that we could use in the future something in between wiki_to_oneliner (too terse in this case) and wiki_to_html (could be too verbose).

WikiDom material ahead: this would be a new "html_excerpt" format which would produce the same output as a the normal "html" but only a limited amount of it, like stop once a given number of words is reached, as computing the actual "height" would be extra hard I imagine.

comment:4 by Auria, 10 years ago

Hi,

I might as well recommend to move the "custom query" link from its current not too visible position in the top-right corner (in small fonts) to appear below other reports perhaps? This may sound silly, but for a long while I didn't like track because I just happened not to notice this link and thus I had trouble searching the bugs

in reply to:  4 comment:5 by Christian Boos, 10 years ago

Replying to Auria:

Not a silly suggestion at all, well, at least I had a similar idea ;-) We could even place the custom query link at the top (see also #9443).

comment:6 by hasienda <hoff.st@…>, 10 years ago

Looks good, definitely will help occasional users or visitors passing by (like top management digging into what their stuff is currently doing). Would you see it reasonable to add a [x] compact display option to (almost) return to current layout? This might be preferred by "power users" that'll never look at descriptions any more, but would value to not have too much clutter and scrolling.

OT: Did I mention I like live-edit-preview in current 0.12? Awesome work, thanks a lot!

comment:7 by hasienda <hoff.st@…>, 10 years ago

Cc: hoff.st@… added

by Christian Boos, 10 years ago

Attachment: new_report_list-2.png added

Show custom query links first, and descriptions hidden by default

by Christian Boos, 10 years ago

Attachment: custom-query-link.patch added

add a link to the last query and to a new custom query at the top of the list of reports. Applies on new_report_list-r10049.patch

by Christian Boos, 10 years ago

Attachment: clear-saved-query.patch added

add the possibility to clear the last saved query, from the report list. Applies on custom-query-link.patch

by Christian Boos, 10 years ago

add a Show Descriptions toggle for the report list, defaults off. Applies on clear-saved-query.patch

comment:8 by Christian Boos, 10 years ago

From the suggestions in comment:4 and comment:6, the new report list could look like this:

Show custom query links first, and descriptions hidden by default

However, when the descriptions are not shown, the Edit/Delete buttons are maybe positioned a bit ambiguously, so I'll also try to put them on the heading line.

by Christian Boos, 10 years ago

Descriptions folded

by Christian Boos, 10 years ago

Descriptions expanded

comment:9 by Christian Boos, 10 years ago

"Last" finishing touch…

With the descriptions visible: Descriptions expanded

With the descriptions folded (default): Descriptions folded

The correspondence between the Edit/Delete buttons with the report is improved over the version from comment:8.

Version 0, edited 10 years ago by Christian Boos (next)

comment:10 by Remy Blank, 10 years ago

Very nice! One very minor nitpick: I would use "Sort by: Identifier ^ Title" instead of "Sorted by: Identifier ^ Title".

comment:11 by hasienda <hoff.st@…>, 10 years ago

I like it too. And +1 for Remy's suggestion to improve on logic/wording.

comment:12 by Christian Boos, 10 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: newclosed

Patch sequence committed in [10088:10098/trunk].

Unfortunately I managed to mess up the first commit r10088, hence the extra r10089 to fix it.

comment:13 by Christian Boos, 10 years ago

Severity: minornormal

comment:14 by Christian Boos, 10 years ago

Hm, I also forgot to run the functional tests, which caught a few XHTML validation errors.

Fixed now with [10103].

comment:15 by Christian Boos, 10 years ago

Resolution: fixed
Status: closedreopened

Little glitch with the list of reports in csv and tsv formats:

  File "build/bdist.linux-x86_64/egg/trac/ticket/report.py", line 267, in _render_list
    filename='reports.csv')
  File "build/bdist.linux-x86_64/egg/trac/ticket/report.py", line 754, in _send_csv
    row[i] = converters[i](row[i]).encode('utf-8')
IndexError: list index out of range

in reply to:  15 comment:16 by Christian Boos, 10 years ago

Resolution: fixed
Status: reopenedclosed

Replying to cboos:

Little glitch with the list of reports in csv and tsv formats:

Fixed in r10218.

comment:17 by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Do you think the behavior of the Show Descriptions toggle could be more widely applicable, for example, applying the behavior to the two filters on the Roadmap page? Or could that be a bad idea for the roadmap page because the page load time will always be the same as what we see now when all of the milestones are show? I'm asking myself the same question for the timeline page.

comment:18 by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Cc: ryan.j.ollos@… added

in reply to:  17 comment:19 by Christian Boos, 8 years ago

Replying to Ryan J Ollos <ryan.j.ollos@…>:

Do you think the behavior of the Show Descriptions toggle could be more widely applicable, for example, applying the behavior to the two filters on the Roadmap page?

Yes, being able to get an overview of the milestones would be valuable

Or could that be a bad idea for the roadmap page because the page load time will always be the same as what we see now when all of the milestones are show?

Well, having the same load time isn't really a problem. And once you show the description, you have all the details immediately as it's just a show/hide.

I'm asking myself the same question for the timeline page.

I'm not sure if getting a condensed view of the timeline as it is now would bring much. But with #9205, that would be interesting as well.

comment:20 by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Ah, I think we might be talking about two slightly different things here, no doubt due to my poor phrasing of the question.

Having a Show Descriptions for the milestones on the Roadmap seems valuable, and somewhat related to #9073. Did you infer that I was asking directly about whether to add a Show Descriptions checkbox to the Roadmap page?

What I had meant to ask about here, was whether the dynamic client-side showing/hiding of the descriptions would also be good behavior to apply to the existing filters on the Roadmap page (i.e. the Show completed milestones and Hide milestones with no due date filters). Rather than having an Update button and a page reload for showing/hiding completed milestones or those with no due date, could we show/hide those milestones using client-side JavaScript? Presumably, this would requiring rendering all of the milestones in the template, and then hiding some of them based on the filter states. It might get rather complicated if we want to have a no-JS fallback.

in reply to:  20 ; comment:21 by Christian Boos, 8 years ago

Replying to Ryan J Ollos <ryan.j.ollos@…>:

Ah, I think we might be talking about two slightly different things here, no doubt due to my poor phrasing of the question.

Having a Show Descriptions for the milestones on the Roadmap seems valuable, and somewhat related to #9073.

Ah yes, sorry, was mixing this up with #9073. I understand what you meant now.

… could we show/hide those milestones using client-side JavaScript? Presumably, this would requiring rendering all of the milestones in the template, and then hiding some of them based on the filter states. It might get rather complicated if we want to have a no-JS fallback.

Not necessarily, we could have the toggling of the checkbox trigger a request (like the Edit side by side checkbox for wiki pages). But I'm not sure it's a good thing to do when there are multiple controls in one form. We probably need to experiment to see if this feels right or not.

And the alternative consisting of fetching everything then hiding what's not needed at the level of the client is not exactly an optimization. Ok, I did just that here with the report descriptions, but those are usually cheap to retrieve compared to getting the full list of roadmap (#10879).

in reply to:  21 comment:22 by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Replying to cboos:

And the alternative consisting of fetching everything then hiding what's not needed at the level of the client is not exactly an optimization. […]

Yeah, I think you are right. In general it could be worthwhile in a use case that someone is doing a lot of toggling of the filters to get different views, but that certainly wouldn't seem to be the typical use case here.

comment:23 by anonymous, 6 years ago

This is broken in 1.0-stable branch, "Show Descriptions" does nothing, and its always shown

comment:24 by Ryan J Ollos, 6 years ago

I guess we can discuss in #11724.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.