Edgewall Software
Modify

Opened 9 years ago

Last modified 5 years ago

#9510 new defect

Action block stays visible when no actions available

Reported by: fredck@… Owned by:
Priority: normal Milestone: next-major-releases
Component: ticket system Version: 0.11-stable
Severity: normal Keywords:
Cc: ethan.jucovy@…, olemis+trac@…, Ryan J Ollos Branch:
Release Notes:
API Changes:

Description

The action block on the ticket page is visible (empty) even if there are no actions available.

I've implemented a custom workflow for our trac site, removing the "leave" action for users that were having just that option (senseless). In that case though, the action block is still there, empty (senseless and ugly now :)).

Attachments (0)

Change History (10)

in reply to:  description ; comment:1 by Remy Blank, 9 years ago

Milestone: 0.13
Owner: set to Remy Blank

Replying to fredck@…:

I've implemented a custom workflow for our trac site, removing the "leave" action for users that were having just that option (senseless).

What would those people do, then, if they can't leave the ticket as-is, and can't change it? :)

We could hide the action block if the only action is to leave the ticket status. But the "leave" workflow action should remain.

in reply to:  1 comment:2 by fredck@…, 9 years ago

Replying to rblank:

What would those people do, then, if they can't leave the ticket as-is, and can't change it? :)

Well, they can still add comments to the tickets ;)

We could hide the action block if the only action is to leave the ticket status. But the "leave" workflow action should remain.

That's a good idea.

comment:3 by Remy Blank, 9 years ago

#9901 was closed as a duplicate, and asks for removal of the "Actions" block when only "leave" is present.

in reply to:  3 comment:4 by Carsten Klein <carsten.klein@…>, 9 years ago

Replying to rblank:

#9901 was closed as a duplicate, and asks for removal of the "Actions" block when only "leave" is present.

cf. 8548#comment:9 for a provable solution to this

comment:5 by Remy Blank, 9 years ago

Milestone: 0.130.14

comment:6 by Remy Blank, 8 years ago

Owner: Remy Blank removed

Refocusing.

comment:7 by ethan.jucovy@…, 6 years ago

Cc: ethan.jucovy@… added

When using ConfigurableTicketWorkflow, if there are no actions available, it's not possible to comment on the ticket or modify the ticket's properties. This also results in a confusing error message 'Warning: The action "view" is not available.' when attempting to submit the ticket-modify form.

So I think that, when no actions are available, either a "leave"-type action should be injected into the page, or the "Modify Ticket" and "Leave a Comment" forms should be disabled, perhaps with a warning. And/or the 'Warning: The action "view" is not available.' message should be replaced with something that points to a possible configuration problem in [ticket-workflow].

I guess this issue is distinct from hiding the "actions" box when only one action is available, but the OP here describes removing the "leave" action altogether, which would lead to this problem.

See #11476 which was closed as a duplicate.

comment:8 by Olemis Lang <olemis+trac@…>, 6 years ago

Cc: olemis+trac@… added

comment:9 by Ryan J Ollos, 6 years ago

Cc: Ryan J Ollos added

comment:10 by Ryan J Ollos, 5 years ago

Milestone: next-dev-1.1.xnext-major-releases

Retargetting tickets to narrow focus for milestone:1.2. Please move the ticket back to milestone:next-dev-1.1.x if you intend to resolve it by milestone:1.2.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned. Next status will be 'new'.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.