Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

#907 closed defect (fixed)

Closing font-style tags ('', ''', ~~ and __) are not recognized around an intra-trac link

Reported by: Juanma Barranquero Owned by: Jonas Borgström
Priority: low Milestone: 0.8
Component: wiki system Version: devel
Severity: minor Keywords: patch
Cc: Branch:
Release Notes:
API Changes:

Description (last modified by Christopher Lenz)

Wiki links like

'''ticket:1'''

incorrectly generate HTML links like this one:

<strong><a title="" class="missing" href="/trac/ticket/1'''">ticket:1'''?</a></strong>

I'm no expertin WikiFormatter.py, but the attached patch seems to fix the problem.

Attachments (2)

WikiFormatter.diff (732 bytes ) - added by Juanma Barranquero 15 years ago.
Patch to fix intra-trac links inside font styles.
ticket907.patch (1.6 KB ) - added by Christopher Lenz 15 years ago.
Combined patch with additional unit test

Download all attachments as: .zip

Change History (5)

by Juanma Barranquero, 15 years ago

Attachment: WikiFormatter.diff added

Patch to fix intra-trac links inside font styles.

by Christopher Lenz, 15 years ago

Attachment: ticket907.patch added

Combined patch with additional unit test

comment:1 by Christopher Lenz, 15 years ago

Component: generalwiki
Description: modified (diff)
Keywords: patch added; links removed
Priority: normallow

I think the patch looks good, and have just added a new patch including the original but with an added unit test for the expected behavior.

I'll leave it to jonas to actually check in this change, as I'm far too uncertain about touching the Wiki formatter myself at this point.

comment:2 by Jonas Borgström, 15 years ago

Status: newassigned

ok, I'll take a look…

comment:3 by Jonas Borgström, 15 years ago

Resolution: fixed
Status: assignedclosed

Fixed in [1045], thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.