id summary reporter owner description type status priority milestone component version severity resolution keywords cc branch changelog apichanges internalchanges 9039 Search within changeset contents(diffs) Ryan J Ollos "I find the labeling of the checkbox '''Changesets''' on the search page is a bit misleading. One might expect the search to include the content of the changesets (text and/or property modifications of files from the version control system), whereas only the '''Revision Properties''' are searched (''Author'', ''Revision'', and ''Message'', as can be seen [source:/trunk/trac/versioncontrol/web_ui/changeset.py@9157:1104#L1093 here]). Initially I thought it might be best to change the label from '''Changesets''' -> '''Revision logs''' for consistency with terminology used in Trac, namely: TracRevisionLog, however: * The term '''Revision logs''' might imply results would contain a link to the [/log RevisionLog] page, whereas a link to a changeset is returned in the search results. * `CHANGESET_VIEW` permission is required to obtain search results for this checkbox, as can be seen [source:trunk/trac/versioncontrol/web_ui/changeset.py@9157:1094,1113#L1093 here] so this suggestions could be similarly confusing. The best alternative I could come up with is to rename the checkbox to '''Revision properties''', which is a term consistently used to refer to Subversion revision properties (i.e. revision meta-data). However, a [/search?q=""revision+properties""&noquickjump=1&wiki=on search] shows that this term is not used anywhere in the Trac documentation to refer to Changelog properties, so it might be inconsistent with terminology used in Trac. It also appears that Trac is leaning towards supporting Mercurial and other vc backends, and I'm not sure what terminology is typically used with those VC systems. Another alternative would be to label the checkbox '''Changeset properties'''. The downside I see with both '''Revision properties''' and '''Changeset properties''' is that the terms are a bit long and might disrupt the nice layout of the [/search Search page]. I hope I am not making too big of a deal about a small thing, but little things like this that need clarification seem to eat up a lot of my time answering questions from developers, and reduce user efficiency using the system. Ultimately, this comes down to either a [source:trunk/trac/versioncontrol/web_ui/changeset.py?rev=9157&marks=1095#L1093 one-line change] or closing this as ''won't fix'', so I set it for milestone:0.12." enhancement new normal unscheduled search system 0.12dev normal