Changes between Initial Version and Version 1 of Ticket #8790, comment 30
- Timestamp:
- Apr 22, 2017, 4:33:30 PM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #8790, comment 30
initial v1 1 1 Thanks for spotting. 2 2 3 Unrelated, the call to `create_logger` in `trac/admin/web_ui.py` registers a handler if it succeeds. I wasn't worried about that because the environment is shutdown after a configuration change, thusdestroying the logger. However I think it would be better to avoid adding the handler to the logger and to close the handler immediately after it's created. Possible fix: [efb1399d/rjollos.git].3 Unrelated, the call to `create_logger` in `trac/admin/web_ui.py` registers a handler if it succeeds. I wasn't worried about that because the environment is shutdown after a configuration change, destroying the logger. However I think it would be better to avoid adding the handler to the logger and to close the handler immediately after it's created. Possible fix: [efb1399d/rjollos.git].