Thanks for the report.
The keywords field for this ticket must have been NULL in the database, for some reason.
In this case we don't insert this field in the ticket values
dict (L103-104), which implies that when setting the field later on, the _old
dict ends with a None
value (L123-124) in trac/ticket/model.py.
This was done in r7570 in order to fix #4061, so we can't fix the current issue by inserting ''
in values
in this case.
I guess we simply need to accept that _old['keywords']
can eventually be None
.
-
|
|
|
1341 | 1341 | 'EMAIL_VIEW' in req.perm(resource_new or ticket.resource)): |
1342 | 1342 | render_elt = obfuscate_email_address |
1343 | 1343 | elif field == 'keywords': |
1344 | | old_list, new_list = old.split(), new.split() |
| 1344 | old_list, new_list = (old or '').split(), new.split() |
1345 | 1345 | sep = ' ' |
1346 | 1346 | if (old_list, new_list) != (None, None): |
1347 | 1347 | added = [tag.em(render_elt(x)) for x in new_list |
(new
can't possibly be None here, but again, I thought the same about old
at first inspection ;-) )