Edgewall Software

Changes between Initial Version and Version 1 of Ticket #8547


Ignore:
Timestamp:
Aug 5, 2009, 6:22:32 PM (10 years ago)
Author:
Christian Boos
Comment:

Thanks for the report.

The keywords field for this ticket must have been NULL in the database, for some reason.

In this case we don't insert this field in the ticket values dict (L103-104), which implies that when setting the field later on, the _old dict ends with a None value (L123-124) in trac/ticket/model.py.

This was done in r7570 in order to fix #4061, so we can't fix the current issue by inserting '' in values in this case.

I guess we simply need to accept that _old['keywords'] can eventually be None.

  • trac/ticket/web_ui.py

     
    13411341                    'EMAIL_VIEW' in req.perm(resource_new or ticket.resource)):
    13421342                render_elt = obfuscate_email_address
    13431343        elif field == 'keywords':
    1344             old_list, new_list = old.split(), new.split()
     1344            old_list, new_list = (old or '').split(), new.split()
    13451345            sep = ' '
    13461346        if (old_list, new_list) != (None, None):
    13471347            added = [tag.em(render_elt(x)) for x in new_list

(new can't possibly be None here, but again, I thought the same about old at first inspection ;-) )

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #8547

    • Property Owner set to Christian Boos
    • Property Component generalticket system
    • Property Milestone0.11.6
  • Ticket #8547 – Description

    initial v1  
    5959
    6060}}}
     61(see source:tags/trac-0.11.5/trac/ticket/web_ui.py@#L1344)
    6162