h,l keyboard shortcuts

[techtonik <techtonik@…>]

A request to add h and l to move up and down (or better say left and right) the directory tree structure expanding/collapsing leaves as needed.

There is also a bug in j,k shortcuts that they stop work after <Tab> is pressed.

[Christian Boos]

Interesting idea, but there are already two assigned keys that can be used to expand/collapse a directory ('o' and 'Enter'), so I'm not sure adding 'l' would be of great help. Also, in attachment:7074-directory-expand-and-nav.2.patch:ticket:7074​ I use 'l' as a shortcut for getting to the 'l'og view.

[techtonik <techtonik@…>]

I guess existing shortcuts were made after ​Google Experimental Search, but Google uses them to navigate plain top-down list and this is insufficient for convenient tree browsing.

Move up and down the tree actions are more sophisticated than simple expand/collapse. Move down the tree (l key or "right"):

1. if folder is selected
   1.1 if folder is not expanded - expand it
   1.2 if the folder is expanded - move selection to the first child
2. if there is file under cursor - do nothing

Move up the tree (h key - "left"):

1. if expanded folder is selected - collapse the folder
2. if file or collapsed folder is selected - move to parent node

As for existing 'l'og shortcut - it is convenient, but may be too easy to hit 'l' when navigating sources. Can it be replaced by other key, to say 'r' for revision log?

[Christian Boos]

I'll have a second look on this after committing my pending changes to the keyboard navigation.

[Remy Blank]

Should probably not block 0.12.

[Christian Boos]

I'll change the current 'l'og shortcut to 'L'og, so this leaves room for implementing this suggestion in a later version.

[Christian Boos]

Well, nobody else really felt the need for this.

Furthermore, it's really easy to navigate the whole tree using only j, k and o. Moving right is just o then j. Moving left, you'd have to go up to the parent, then o to toggle it closed, then j/k. Ok, maybe going left — h could be handy… but no need to bother people used to typing l for getting to the log view.

[Ryan J Ollos]

Retargetting tickets to narrow focus for milestone:1.2. Please move the ticket back to milestone:next-dev-1.1.x if you intend to resolve it by milestone:1.2.