Edgewall Software
Modify

Opened 14 years ago

Last modified 7 years ago

#7867 new enhancement

h,l keyboard shortcuts

Reported by: techtonik <techtonik@…> Owned by:
Priority: normal Milestone: next-major-releases
Component: version control/browser Version: none
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

A request to add h and l to move up and down (or better say left and right) the directory tree structure expanding/collapsing leaves as needed.

There is also a bug in j,k shortcuts that they stop work after <Tab> is pressed.

Attachments (0)

Change History (8)

comment:1 by Christian Boos, 14 years ago

Interesting idea, but there are already two assigned keys that can be used to expand/collapse a directory ('o' and 'Enter'), so I'm not sure adding 'l' would be of great help. Also, in attachment:7074-directory-expand-and-nav.2.patch:ticket:7074 I use 'l' as a shortcut for getting to the 'l'og view.

comment:2 by techtonik <techtonik@…>, 14 years ago

I guess existing shortcuts were made after Google Experimental Search, but Google uses them to navigate plain top-down list and this is insufficient for convenient tree browsing.

Move up and down the tree actions are more sophisticated than simple expand/collapse. Move down the tree (l key or "right"):

  1. if folder is selected
    1.1 if folder is not expanded - expand it
    1.2 if the folder is expanded - move selection to the first child
  2. if there is file under cursor - do nothing

Move up the tree (h key - "left"):

  1. if expanded folder is selected - collapse the folder
  2. if file or collapsed folder is selected - move to parent node

As for existing 'l'og shortcut - it is convenient, but may be too easy to hit 'l' when navigating sources. Can it be replaced by other key, to say 'r' for revision log?

comment:3 by Christian Boos, 13 years ago

Milestone: 0.12

I'll have a second look on this after committing my pending changes to the keyboard navigation.

comment:4 by Remy Blank, 13 years ago

Milestone: 0.12next-minor-0.12.x

Should probably not block 0.12.

comment:5 by Christian Boos, 12 years ago

Milestone: next-minor-0.12.xnext-major-0.1X

I'll change the current 'l'og shortcut to 'L'og, so this leaves room for implementing this suggestion in a later version.

comment:6 by Christian Boos, 10 years ago

Milestone: next-major-releasesnext-dev-1.1.x
Owner: set to Christian Boos
Status: newassigned

Well, nobody else really felt the need for this.

Furthermore, it's really easy to navigate the whole tree using only j, k and o. Moving right is just o then j. Moving left, you'd have to go up to the parent, then o to toggle it closed, then j/k. Ok, maybe going left — h could be handy… but no need to bother people used to typing l for getting to the log view.

Last edited 10 years ago by Christian Boos (previous) (diff)

comment:7 by Ryan J Ollos, 7 years ago

Owner: Christian Boos removed
Status: assignednew

comment:8 by Ryan J Ollos, 7 years ago

Milestone: next-dev-1.1.xnext-major-releases

Retargetting tickets to narrow focus for milestone:1.2. Please move the ticket back to milestone:next-dev-1.1.x if you intend to resolve it by milestone:1.2.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.