Edgewall Software

Changes between Initial Version and Version 1 of Ticket #7339, comment 17

Aug 19, 2015, 4:05:24 PM (3 years ago)
Ryan J Ollos


  • Ticket #7339, comment 17

    initial v1  
    11Replying to [comment:15 Vaclav Slavik <vslavik@…>]:
    22> I'm attaching modified version of the patch. Changes:
    3 >
    4 > 1. Fixed `trac/ticket/web_ui.py` problem. `Chrome(self.env)` is relatively cheap, so I just added it at the beginning of the function.
    5 > 1. Docstring fixed.
    6 > 1. Changed to show full name even to anonymous requests. Previously, `show_full_names` meant "show full names to users that would otherwise be shown unmangled email address", I think it makes more sense like this.
    7 > 1. If showing email address is permitted, display `Full Name <email@address.com>` instead of `Full Name`. This is consistent with the way email addresses of unauthenticated users are shown by Trac. More importantly, it wouldn't be possible to contact registered submitters without this change.
    8 >
    9 > I'm not sure if 4. is the right thing to do. Ideally, user names would be clickable links (either `mailto:` or using e.g. reCAPTCHA Mailhide), but that would be a huge change out of this patch's scope.
    10 >
    11 > I didn't port the patch to 0.12 and its caching framework yet.
     3> [...]
    135This patch is upside down?