Edgewall Software

Changes between Initial Version and Version 2 of Ticket #7026


Ignore:
Timestamp:
Mar 21, 2008, 1:52:43 PM (14 years ago)
Author:
Christian Boos
Comment:

I tried the patch and it works great. I think the UI is perfect for the non JavaScript case, but with JavaScript enabled, I'm sure we could even make this more intuitive in the future by providing the possibility to simply dragg the column name up and down.

I'm not sure about passing the ordering info (coln). Currently, we simply rely on the order of the col arguments in req.args['col'] to be the same as they appear in the query string. Is there a situation were this wouldn't work? If not, I think the code could be simplified a lot. At the very least, the col parameters without a number should still be supported for backward compatibility and for example, added at the end after the numbered columns.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7026

    • Property Component generalreport system
    • Property Priority normalhigh
    • Property Versiondevel
    • Property Milestone0.12
    • Property Owner changed from Jonas Borgström to Matthew Good
    • Property Type defectenhancement
  • Ticket #7026 – Description

    initial v2  
    33First of all it solves the problem of the poor scalability of the UI for selecting columns to display, which is pretty unusable in situations where there are something on the order of 50 custom fields (which I've seen, and it's ugly).
    44
    5 I also needed the ability to let users reorder the columns, which this solves.  I'm sure how the Trac devs will feel about this.  It replaces the 'col=' query arguments with arguments in the form 'col#=', where # is the order that that column should be displayed in.  This works fine for URL query strings.  But I haven't updated the TracQuery syntax to support column reordering.  Other than that it seems to work fine, and includes support for non-!JavaScript users.
     5I also needed the ability to let users reorder the columns, which this solves.  I'm not sure how the Trac devs will feel about this.  It replaces the 'col=' query arguments with arguments in the form 'col#=', where # is the order that that column should be displayed in.  This works fine for URL query strings.  But I haven't updated the TracQuery syntax to support column reordering.  Other than that it seems to work fine, and includes support for non-!JavaScript users.