#4212 closed defect (fixed)
Unavailable Resolution for Tickets which are solved without code/source change
Reported by: | Owned by: | Jonas Borgström | |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | project | Version: | devel |
Severity: | normal | Keywords: | doc |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
A ticket can affect an issue which can be resolved without a code/source change.
Closing such tickets with the resolution of "fixed" is not allowed.
Thus another resolutions should be provided (e.g. "done", "fulfilled", "other" etc.)
Further information:
see #4039 and TracTicketTriage
Attachments (0)
Change History (11)
follow-up: 2 comment:1 by , 18 years ago
follow-up: 3 comment:2 by , 18 years ago
Replying to cboos:
Well, what is really important is that one can correlate a
fixed
ticket with some changeset when the milestone is set. That way, for every ticket listed as closed for a given milestone, there are some related changes in the repository.
ok
For tickets where no milestone is set, especially for task tickets, I'd say it's ok to use
fixed
when something has been done by us in order to close the issue.
This confronts with the strict rule (Use 'fixed' only for repository trackable changes).
If the resolution is "external", then
worksforme
should preferably be used, I think (to get to the specifics of #4039).
That's it!
If the resolution is "external" (to the managed repository), then… external
should be used.
The missing resolution is: external
External: Chosse the external resolution, if the action taken to solve the ticket is external to the repository of the trac-instance, and thus not trackable by a changeset.
follow-up: 4 comment:3 by , 18 years ago
Replying to ilias@lazaridis.com:
If the resolution is "external" (to the managed repository), then…
external
should be used.
Why not simply worksforme? This resolution label is used for this purpose since a long time.
comment:4 by , 18 years ago
Replying to cboos:
Replying to ilias@lazaridis.com:
If the resolution is "external" (to the managed repository), then…
external
should be used.Why not simply worksforme? This resolution label is used for this purpose since a long time.
Simple: because this is false information.
"works for me" should only be used, if the reported issue "works for <the ticket closing entity>" (without any action taken).
"external" would be used, if the reported issue works after an action was taken (external to the repository).
It should be clear that a distinction is neccessary, although the term "external" is possibly not the most concise one.
follow-up: 6 comment:5 by , 18 years ago
As discussed on the MailingList thread, the worksforme
resolution will be used for resolving these types of issues. Any relevant API changes that are required will be spun into another ticket.
comment:6 by , 18 years ago
Replying to sid:
As discussed on the MailingList thread, the
worksforme
resolution will be used for resolving these types of issues. Any relevant API changes that are required will be spun into another ticket.
Sorry, but I won't go into the details of this thread which interweaves several issues.
Following the standard-processes of this project, I've filed this valid ticket subjecting a specific issue. Thus I expect that the rationales for handling this specific issue (ticket) here.
You can verify my defect report very simple:
- Open a new task
- Fulfill the task with some action (external to the repository)
- Close this task with 'worksforme'
- Read the status:
- Ticket #10 (closed task: worksforme)
This information is false.
the needed resolutions is: fulfilled, resulting in a clean status:
- Ticket #10 (closed task: fulfilled)
I think it becomes clear that "worksforme" has nothing to do there.
If you still insist, please close this ticket as "worksforme", "wontfix" or whatever else you like.
comment:7 by , 18 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Type: | defect → task |
As cboos said in the first comment closing "task" tickets as "fixed" is OK as long as they required an action on the part of the developers which was completed. What we're trying to avoid is people closing a defect as "fixed" when it was simply a configuration error, or other user error. These don't represent an actual defect in Trac, so they should not be closed as "fixed". The "worksforme" resolution is appropriate since it does work correctly when Trac is configured correctly.
comment:8 by , 18 years ago
Keywords: | doc added |
---|---|
Resolution: | wontfix |
Status: | closed → reopened |
Type: | task → defect |
reopening this ticket, which described a defect (ticket type = defect) of the project (Component = project) documentation (keyword = doc).
comment:9 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
the described defect was fixed, due to the following change in the documentation:
http://trac.edgewall.org/wiki/TracTicketTriage?action=diff&version=21
comment:10 by , 18 years ago
I don't agree with the resolution.
The information given by "worksforme" is false.
Trac will be used even to track other projects. You cannot build the Trac project based on a wiki page that probably will be different on other projects.
Regards,
comment:11 by , 18 years ago
Well, worksforme is not even an english word, AFAICT ;-)
Consider it like a code, which roughly means that ticket no longer needs to remain opened, but nevertheless don't count it as being fixed.
Additional resolution types fitting different needs will soon be possible, see e.g. #905.
Well, what is really important is that one can correlate a
fixed
ticket with some changeset when the milestone is set. That way, for every ticket listed as closed for a given milestone, there are some related changes in the repository.For tickets where no milestone is set, especially for task tickets, I'd say it's ok to use
fixed
when something has been done by us in order to close the issue. If the resolution is "external", thenworksforme
should preferably be used, I think (to get to the specifics of #4039).