Edgewall Software

Changes between Initial Version and Version 1 of Ticket #3517, comment 21


Ignore:
Timestamp:
Aug 25, 2015, 9:43:44 PM (7 years ago)
Author:
Peter Suter

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3517, comment 21

    initial v1  
    22> `TicketNotifyEmail` and `BatchTicketNotifyEmail` are marked as deprecated ([13578]), but methods of the classes are called in `TicketFormatter`. Is the plan to move those methods to the `TicketFormatter` class when `TicketNotifyEmail` and `BatchTicketNotifyEmail` are removed?
    33
    4 I think that's exactly what should be done, yes.
     4I think that's exactly what should be done, yes. (The formatting logic of those classes is perfectly fine. The problem with them was the coupling of formatting, sending and recipients gathering, with missing hooks for effective customization. Perhaps more subjectively that inheritance chain has a bit of a [wikipedia:"Yo-yo problem"].)