download in original format of source attachments fails (.bat and .py)

[patrickmmartin@…]

got to

​http://projects.edgewall.com/trac/attachment/ticket/1602/trac-post-commit-hook_4bat

and click on the original format link

I got an error once.

Amusingly, not the second time.

So I'm afraid all I can remember is something about "not iterable" and mime-type

[anonymous]

got this error again on downloading a .py attachment, this time

​http://projects.edgewall.com/trac/attachment/ticket/1602/trac-pre-commit-hook_4bat.2

and here's the traceback

Traceback (most recent call last):

File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 299, in dispatch_request

dispatcher.dispatch(req)

File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 189, in dispatch

resp = chosen_handler.process_request(req)

File "/usr/lib/python2.3/site-packages/trac/attachment.py", line 289, in process_request

self._render_view(req, attachment)

File "/usr/lib/python2.3/site-packages/trac/attachment.py", line 444, in _render_view

if 'charset=' not in mime_type:

TypeError: iterable argument required

This one seems 100% reproducible now.

Using IE 6

I went to

​http://projects.edgewall.com/trac/wiki/TracOnWindows

clicked on new window for the link

​http://projects.edgewall.com/trac/ticket/1602

and clicked on new window for the links for the attachments I wanted.

Then go to the original format link

[Christian Boos]

I believe this was fixed in r3225 (and this Trac is certainly running using a slightly older rev).

[patrickmmartin@…]

Is this fix in a testable release, or should this report be closed now?

[Matthew Good]

This is working on the attachments to #1602 mentioned above now that the site has been updated, so I believe that [3225] did resolve the problem.