Opened 18 years ago
Last modified 17 years ago
#2432 closed defect
Wiki timeline URLs should contain the version — at Initial Version
Reported by: | Owned by: | Jonas Borgström | |
---|---|---|---|
Priority: | high | Milestone: | 0.11 |
Component: | timeline | Version: | 0.9 |
Severity: | major | Keywords: | rss |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
URLs constructed on the timeline page and rss version for changes to Wiki pages only contain links to the Wiki page that was changed, not to the actual version of the Wiki page. This leads to non-unique URLs in the rss feeds which break many readers, as well as having links on the timeline to non specific Wiki page versions. This patch corrects this issue:
—- trac/wiki/web_ui.py.old 2005-12-01 16:51:58.000000000 -0500 +++ trac/wiki/web_ui.py 2005-12-01 16:51:09.000000000 -0500 @@ -129,18 +129,18 @@
format = req.args.get('format') db = self.env.get_db_cnx() cursor = db.cursor()
- cursor.execute("SELECT time,name,comment,author "
+ cursor.execute("SELECT time,name,comment,author,version "
"FROM wiki WHERE time≥%s AND time⇐%s", (start, stop))
- for t,name,comment,author in cursor:
+ for t,name,comment,author,version in cursor:
title = '<em>%s</em> edited by %s' % (
escape(name), escape(author))
if format == 'rss':
- href = self.env.abs_href.wiki(name)
+ href = escape(self.env.abs_href.wiki(name,version=version))
comment = wiki_to_html(comment or '—', self.env, db,
absurls=True)
else:
- href = self.env.href.wiki(name)
+ href = escape(self.env.href.wiki(name,version=version))
comment = wiki_to_oneliner(comment, self.env, db,
shorten=True)
yield 'wiki', href, title, t, author, comment