Edgewall Software

Changes between Initial Version and Version 1 of Ticket #2311, comment 19


Ignore:
Timestamp:
Oct 3, 2013, 3:07:43 AM (7 years ago)
Author:
Ryan J Ollos

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2311, comment 19

    initial v1  
    11The patch in [https://github.com/rjollos/trac/commit/25165a4599d6cba5c03af22656e6f7400395a1f5 25165a45] causes the previous owner to be notified when a ticket is reassigned. This was implemented by patterning the change after the way that `prev_cc` is handled: populating the field in `_notify` and then passing the value of the field as a parameter to the `get_ticket_notification_recipients` method.
    22
    3 The patch in [https://github.com/rjollos/trac/commit/bcd8df9a90e52d3226f0186738853a73b5191347 bcd8df9a] implements the same change in a different way, by isolating all of work in populating the recipients list to the `get_ticket_notification_recipients` method. I tend to think this leads to more readable.
     3The patch in [https://github.com/rjollos/trac/commit/bcd8df9a90e52d3226f0186738853a73b5191347 bcd8df9a] implements the same change in a different way, by isolating all of work in populating the recipients list to the `get_ticket_notification_recipients` method. I tend to think this leads to more readable code.
    44
    55Neither patch causes the previous owner to be notified in the case of batch modification, and a similar pre-existing problem is that members removed from the CC list are not notified when the ticket is batch modified. It looks like the way to fix that issue is to pass the `modtime` to `BatchTicketNotifyEmail.notify`. The second of the two patches will probably make this problem easier to fix.