Edgewall Software

Opened 3 years ago

Last modified 2 years ago

#13299 closed enhancement

Make wiki upgrade less verbose — at Version 3

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.4.3
Component: wiki system Version:
Severity: normal Keywords: trac-admin
Cc: Branch:
Release Notes:

Removed print to console of up to date wiki pages on TracAdmin wiki upgrade.

API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

Example of upgrading a 1.2 environment to 1.4:

$ trac-admin env1 wiki upgrade
  TracAdmin is already up to date
  TracCgi is already up to date
  TracBatchModify is already up to date
  TracBackup is already up to date
  TicketQuery is already up to date
  InterMapTxt already exists
  WikiRestructuredTextLinks is already up to date
  TracSupport is already up to date
  TracRss is already up to date
  RecentChanges is already up to date
  TitleIndex is already up to date

I don't think the information is useful to administrators. Instead, we could log the output at INFO level, like was done in #12966, and print

$ trac-admin env1 wiki upgrade
Upgrade done: 14 pages upgraded.

Then, it will be more concise, like the environment upgrade:

$ trac-admin env1 upgrade
Upgrade done.

You may want to upgrade the Trac documentation now by running:

  trac-admin "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/env1" wiki upgrade

Change History (3)

comment:1 by Ryan J Ollos, 3 years ago

Component: generalwiki system
Description: modified (diff)
Keywords: trac-admin added

comment:2 by Ryan J Ollos, 3 years ago

[16472#file8] changed load_pages to not echo the page imported, but load_pages is called by _load_or_replace, which is called for wiki load and wiki replace, so the loaded or replaced page names are no longer printed to the terminal.

I'll fix that issue and add test coverage for the trac-admin wiki commands.

comment:3 by Ryan J Ollos, 2 years ago

Release Notes: modified (diff)
Note: See TracTickets for help on using tickets.