Edgewall Software
Modify

Opened 2 years ago

Closed 2 years ago

Last modified 22 months ago

#13280 closed defect (fixed)

Skip commits on AppVeyor

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.20
Component: general Version:
Severity: normal Keywords: appveyor
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Appveyor will not run builds when commits contain only files in trac/locale/ or trac/wiki/default-pages/.

Description

32546122 ran even though the message contained [skip ci]. It looks like we need to setup commit filtering.

Also, we can configure to skip commits matching only files in trac/locale, in case we forget to specify [skip ci].

Attachments (0)

Change History (8)

comment:1 by Ryan J Ollos, 2 years ago

NOTE: Similarly to custom skip commit message, AppVeyor searches for [skip ci] / [ci skip] / [skip appveyor] in the commit message title only. This avoids confusion when squashing commits, in particular with the GitHub squash-and-merge feature.

That differs from Travis CI and I'm not sure we want to start putting [skip ci] in the title.

We could cover most cases with:

  • .appveyor.yml

    diff --git a/.appveyor.yml b/.appveyor.yml
    index 5390dfabe..79a9eebf5 100644
    a b  
    11version: '{branch}.{build}'
    22clone_depth: 20
     3skip_commits:
     4  files:
     5    - trac/locale/
     6    - trac/wiki/default-pages/
    37init:
    48- ps: >-
    59    # Note 1: in 'Environment variables' groups above, use:
    test_script:  
    4549
    4650    Trac-Tests
    4751artifacts:
    48 - path: 'dist\*'
    49  No newline at end of file
     52- path: 'dist\*'

comment:2 by Ryan J Ollos, 2 years ago

Internal Changes: modified (diff)

comment:3 by Ryan J Ollos, 2 years ago

Resolution: fixed
Status: assignedclosed

Committed in [17286:17289].

comment:4 by Ryan J Ollos, 2 years ago

Might be more effective to use a rule like the following:

only_commits:
  files:
    - .appveyor
    - contrib/appveyor.ps1
    - setup.py
    - trac/**/*.py
    - trac/**/*.html
    - tracopt/**/*.py
    - tracopt/**/*.html
Version 0, edited 2 years ago by Ryan J Ollos (next)

comment:5 by Ryan J Ollos, 2 years ago

The path is appended each of the 3 times the AppVeyor script is run: see build 33182015.

Trac-Install

Path not printed

But, presumably it would be:

PYTHONPATH=.:C:\projects\dependencies\2.7\svn-win32-1.8.15\python

Trac-Build

Path appended twice:

PYTHONPATH=.:C:\projects\dependencies\2.7\svn-win32-1.8.15\python;C:\projects\dependencies\2.7\svn-win32-1.8.15\python;

Trac-Tests

Path appended thrice:

PYTHONPATH=.:C:\projects\dependencies\2.7\svn-win32-1.8.15\python;C:\projects\dependencies\2.7\svn-win32-1.8.15\python;C:\projects\dependencies\2.7\svn-win32-1.8.15\python;

Proposed change:

comment:6 by Ryan J Ollos, 2 years ago

comment:5 change committed in r17393, merged in r17394, r17395, r17396.

comment:7 by Ryan J Ollos, 2 years ago

comment:4 change committed in r17442, merged in [17445:17447].

comment:8 by Ryan J Ollos, 22 months ago

r17470 and r17471 didn't run on AppVeyor. Added trac/**/*.txt to only_commits patterns in [17472:17475]:

$ find trac -name "*.txt"
trac/web/tests/console-tests.txt
trac/tests/attachment-console-tests.txt
trac/tests/console-tests.txt
trac/admin/tests/console-tests.txt
trac/wiki/tests/wiki-tests.txt
trac/wiki/tests/wikicreole-tests.txt
trac/versioncontrol/tests/console-tests.txt
trac/versioncontrol/templates/revisionlog.txt
trac/ticket/tests/console-tests.txt
trac/ticket/templates/batch_ticket_notify_email.txt
trac/ticket/templates/ticket_notify_email.txt

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.