Edgewall Software

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13117 closed enhancement (fixed)

Add clear parameter to the BR macro — at Version 6

Reported by: Christian Boos Owned by: Christian Boos
Priority: normal Milestone: 1.3.4
Component: wiki system Version: 1.3dev
Severity: normal Keywords:
Cc: Branch: log:cboos.git@t13117-wikimacro-BR-clear
Release Notes:

The BR macro takes an optional "clear" parameters, which adds the corresponding CSS styling (i.e. [[br(clear:left)]] generates the HTML <br style="clear: left"/>, same thing for "right" or "clear"). Note that [[br(clear)]] stands for [[br(clear:both)]].

API Changes:
Internal Changes:

Description (last modified by Christian Boos)

I had to write [[html(<br style="clear: left"/>)]] once too many…

Such HTML snippets are very useful at times but are a bit painful to write, not to mention it feels like a hack…

Being able to use the BR "macro" for that feels much more natural: 

[[br(clear:left)]]

or: 

[[br(clear=left)]]

[[br(clear)]] alone would stand for [[br(clear:both)]].

I think [[br]] is probably not much used since the introduction of the WikiCreole equivalent \\, but as it's still there in the code and documented in WikiFormatting, why not making it more useful?

See log:cboos.git@t13117-wikimacro-BR-clear.

Change History (6)

comment:1 by Christian Boos, 5 years ago

Description: modified (diff)

comment:2 by Ryan J Ollos, 5 years ago

Looks good to me.

comment:3 by Christian Boos, 5 years ago

Branch: → log:cboos.git@t13117-wikimacro-BR-clear

comment:4 by Christian Boos, 5 years ago

API Changes: modified (diff)
Resolution: → fixed
Status: new → closed

Committed in r16877.

comment:5 by Christian Boos, 5 years ago

Owner: set to Christian Boos

comment:6 by Christian Boos, 5 years ago

API Changes: modified (diff)
Release Notes: modified (diff)
Note: See TracTickets for help on using tickets.