Opened 5 years ago
Closed 5 years ago
#13116 closed enhancement (fixed)
A few stylistic improvements (#12640)
| Reported by: | Christian Boos | Owned by: | Christian Boos |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.3.4 |
| Component: | general | Version: | 1.3dev |
| Severity: | normal | Keywords: | pullrequest css |
| Cc: | Branch: | log:cboos.git@t12640-refinement.5 log:cboos.git@t13116-experimental.1 | |
| Release Notes: |
Improved styling of wiki and ticket pages. |
||
| API Changes: | |||
| Internal Changes: | |||
Description (last modified by )
I had these changes locally for almost a year (and a half)…
Finally getting around to commit them, but as it's been a long time, I'd like to ask for a code review.
[OT] what about a new "pull request" ticket type?
Attachments (0)
Change History (11)
follow-up: 4 comment:2 by , 5 years ago
Replying to Christian Boos:
[OT] what about a new "pull request" ticket type?
Or we could use a keyword, since "pull request" and task/defect/enhancement are not mutually exclusive.
comment:4 by , 5 years ago
| Keywords: | pullrequest added |
|---|
Replying to Ryan J Ollos:
Replying to Christian Boos:
[OT] what about a new "pull request" ticket type?
Or we could use a keyword, since "pull request" and task/defect/enhancement are not mutually exclusive.
Well, I suggested a ticket type as I was thinking about type-specific workflow, type-specific fields and type-specific presentation… I ought to know that this is not yet possible ;-) So in the meantime, sure, a keyword would do!
comment:5 by , 5 years ago
| Branch: | → log:cboos.git@t12640-refinement.5 |
|---|---|
| Description: | modified (diff) |
| Owner: | set to |
| Status: | new → assigned |
follow-up: 7 comment:6 by , 5 years ago
Changesets from the branch committed in [16866:16871].
There are two additional stylistic changes in log:cboos.git@t13116-experimental, you can see them in testing (check #444 there). It's WIP.
comment:7 by , 5 years ago
| Branch: | log:cboos.git@t12640-refinement.5 → log:cboos.git@t12640-refinement.5 log:cboos.git@t13116-experimental |
|---|
Replying to Christian Boos:
There are two additional stylistic changes … you can see them in testing (check #444 there)
So I think I reached what I wanted there. Opinions?
comment:8 by , 5 years ago
| Branch: | log:cboos.git@t12640-refinement.5 log:cboos.git@t13116-experimental → log:cboos.git@t12640-refinement.5 log:cboos.git@t13116-experimental.1 |
|---|
comment:11 by , 5 years ago
| Release Notes: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Committed to trunk in r16918.
In comment:27:ticket:633 and comment:29:ticket:633, I suggest that font-size of root element should be fixed (14px). The fixed font-size is conflicted with changes for unit length in the proposed changes. Please check the changes with the fixed font-size.