Changes between Initial Version and Version 1 of Ticket #13042
- Timestamp:
- Jun 13, 2018, 3:06:45 AM (6 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #13042 – Description
initial v1 1 The [browser:tags/trac-1.3.2/trac/web/api.py@:770-794#L768 Request.send_error] method has a local import for `Chrome` and does the work of loading and rendering the error template. For a normal request the work is done in `trac.web.main`. I propose having a `_send_error` method in `trac.web.main` that does the work of loading and rendering the error template. 1 The [browser:tags/trac-1.3.2/trac/web/api.py@:770-794#L768 Request.send_error] method has a method-scoped import for `Chrome` and does the work of loading and rendering the error template. 2 3 For a normal request the work of rendering a template is done in `trac.web.main`. I propose having a `_send_error` method in `trac.web.main` that does the work of loading and rendering the error template, and have `Request.send_error` behave more like `Request.send`.