Edgewall Software

Changes between Initial Version and Version 1 of Ticket #12968


Ignore:
Timestamp:
Jan 2, 2018, 4:53:43 PM (6 years ago)
Author:
Jun Omae
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12968 – Description

    initial v1  
    1 Lines 50 and 51 of preview_file.html of rev 16379 need to be swapped so that the final "</p>" on line 51 is enclosed in the final "# endif", otherwise the dangling </p> generated by preview_file.html will report the error "ParseError: mismatched tag: line ###, column #" when trying to view a file in the repo.
     1Lines 50 and 51 of preview_file.html of r16379 need to be swapped so that the final `</p>` on line 51 is enclosed in the final `# endif`, otherwise the dangling `</p>` generated by preview_file.html will report the error `ParseError: mismatched tag: line ###, column #` when trying to view a file in the repo.
    22
    3 Please see preview_file.html rev 16379: https://trac.edgewall.org/browser/trunk/trac/templates/preview_file.html?rev=16379#L51
     3Please see preview_file.html rev 16379: source:/trunk/trac/templates/preview_file.html@16379#L51
    44
    5 In the current trunk source code, this can be reproduced simply by clicking on any link to a file in the repo that results in use of the "browser.html" template that includes preview_file.html.
     5In the current trunk source code, this can be reproduced simply by clicking on any link to a file in the repo that results in use of the `browser.html` template that includes preview_file.html.
    66
    77I've attached a patch that solves for this bug.