Edgewall Software
Modify ↓

Opened 7 years ago

Closed 7 years ago

#12890 closed defect (fixed)

Remove fieldsets which have had iefix class

Reported by: Jun Omae Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2.3
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Removed unintended fieldset around ticket description field.

API Changes:
Internal Changes:

Description (last modified by Jun Omae)

fieldset.iefix has been added in [979] to avoid some old IE bugs. The fieldset element wraps textarea element for wikitext but is not visible. The fieldset.iefix has no borders, no margins and no padding.

The fieldset.iefix has been removed and iefix class has been removed from fieldset elements in [11129] but fieldsets still remains. Then, the fieldset element became to be visible because fieldset rule in trac.css is applied.

Trac 1.0 and later:

Trac 0.12 and early:

But I think it is unintentional, and that is not cool.

I consider we should remove the fieldset elements which wrap textarea.wikitext because fieldset.iefix is not available.

Attachments (5)

fieldset.png​ (30.5 KB ) - added by Jun Omae 7 years ago.
fieldset-0.12.png​ (7.1 KB ) - added by Jun Omae 7 years ago.
Screen Shot 2017-08-11 at 01.51.59.png​ (27.0 KB ) - added by Ryan J Ollos 7 years ago.
Screen Shot 2017-08-21 at 01.15.16.png​ (82.9 KB ) - added by Ryan J Ollos 7 years ago.
Screen Shot 2017-08-21 at 01.18.32.png​ (110.8 KB ) - added by Ryan J Ollos 7 years ago.

Download all attachments as: .zip

Change History (12)

by Jun Omae, 7 years ago

Attachment: fieldset.png​ added

by Jun Omae, 7 years ago

Attachment: fieldset-0.12.png​ added

comment:1 by Jun Omae, 7 years ago

Description: modified (diff)

by Ryan J Ollos, 7 years ago

Attachment: Screen Shot 2017-08-11 at 01.51.59.png​ added

comment:2 by Ryan J Ollos, 7 years ago

Removing the fieldset looks good to me. On trunk at least, for label.trac-textarea-hint I would also set line-height to 100% and margin-bottom to 0.5em. Or do some other tweaks that add more space below the You may use WikiFormatting here and move it closer to the textarea.

Version 0, edited 7 years ago by Ryan J Ollos (next)

comment:3 by Ryan J Ollos, 7 years ago

Owner: set to Ryan J Ollos
Release Notes: modified (diff)
Status: new → assigned

comment:4 by Ryan J Ollos, 7 years ago

Release Notes: modified (diff)

Fieldset removed in r16246, merged to trunk in r16247. I'll look at proposing some stylesheet changes for the trunk.

Last edited 7 years ago by Ryan J Ollos (previous) (diff)

by Ryan J Ollos, 7 years ago

Attachment: Screen Shot 2017-08-21 at 01.15.16.png​ added

by Ryan J Ollos, 7 years ago

Attachment: Screen Shot 2017-08-21 at 01.18.32.png​ added

comment:5 by Ryan J Ollos, 7 years ago

Proposed changes for trunk in [2d9e19bd9/rjollos.git].

comment:6 by Jun Omae, 7 years ago

Looks good to me.

comment:7 by Ryan J Ollos, 7 years ago

Resolution: → fixed
Status: assigned → closed

Thanks, committed in r16266.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.