Changes between Initial Version and Version 1 of Ticket #12857

Timestamp:

Oct 3, 2017, 1:37:32 AM (7 years ago)

Author:

Ryan J Ollos

Comment:

Any value other than 1 results in the checkbox defaulting to 0: tags/trac-1.2.2/trac/ticket/templates/ticket.html@:267#L244​.

I considered using as_int, but maybe better to use as_bool:

• trac/ticket/api.py

  diff --git a/trac/ticket/api.py b/trac/ticket/api.py
  index ea15d77a0..05f757a8d 100644

  a	b	from trac.config import (
  27	27	from trac.core import *
  28	28	from trac.perm import IPermissionRequestor, PermissionCache, PermissionSystem
  29	29	from trac.resource import IResourceManager
  30		from trac.util import Ranges, as_int
  	30	from trac.util import Ranges, as_bool, as_int
  31	31	from trac.util.text import shorten_line
  32	32	from trac.util.translation import _, N_, deactivate, gettext, reactivate
  33	33	from trac.wiki import IWikiSyntaxProvider, WikiParser
  …	…	class TicketSystem(Component):
  422	422	field['optional'] = True
  423	423	if '' in field['options']:
  424	424	field['options'].remove('')
  	425	elif field['type'] == 'checkbox':
  	426	field['value'] = '1' if as_bool(field['value']) else '0'
  425	427	elif field['type'] == 'text':
  426	428	field['format'] = config.get(name + '.format', 'plain')
  427	429	elif field['type'] == 'textarea':

That would allow checkbox.value = true to be accepted. We don't need to document that as allowed, but it might be better fallback behavior.

>>> from trac.env import Environment
>>> from trac.ticket.model import Ticket
>>> env = Environment('/Users/rjollos/Documents/Workspace/trac-dev/tracenvs/proj-1
.2')
>>> env.config.get('ticket-custom', 'checkbox1.value')
u'42'
>>> ticket = Ticket(env)
>>> ticket['summary'] = 'via plugin'
>>> ticket.insert()
21
>>> for name in sorted(ticket.values): name, ticket[name]
...
('changetime', datetime.datetime(2017, 10, 2, 23, 28, 12, 648549, tzinfo=<FixedOff
set "UTC" 0:00:00>))
(u'checkbox1', 1)
('owner', u'< default >')
('priority', u'blocker')
('summary', 'via plugin')
('time', datetime.datetime(2017, 10, 2, 23, 28, 12, 648549, tzinfo=<FixedOffset "U
TC" 0:00:00>))