Edgewall Software

Changes between Initial Version and Version 1 of Ticket #12813


Ignore:
Timestamp:
May 20, 2017, 7:22:12 AM (3 years ago)
Author:
Ryan J Ollos
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12813 – Description

    initial v1  
    1 [th:VotePlugin] needs to get the `resource` for a request. It currently does this in a way that isn't entirely robust, see [th:browser:voteplugin/trunk/tracvote/__init__.py@16224#L83 resource_from_path]. I seem to remember the issue coming up for other plugins as well.
     1[th:VotePlugin] needs to get the `resource` for a request. It currently does this in a way that isn't entirely robust, see [th:browser:voteplugin/trunk/tracvote/__init__.py@16224#L83 resource_from_path].
    22
    33The reason the method isn't robust is that it assume the path `/` corresponds to `wiki/WikiStart`, but this depends on [[TracIni#trac-default_handler-option|[trac] default_handler]] and the [/prefs/userinterface session preference] for default handler.
    44
     5I seem to remember the issue coming up for other plugins as well.
     6
    57Initially I considered adding a function `resource_from_request`. However, maybe it would make the most sense to setup a [browser:trunk/trac/web/main.py@15870#L311 callback] and make the resource available as `req.resource`?