Tests fail with Subversion 1.6 or early: WindowsError: [Error 5] Access is denied

[anonymous]

C:\Trac>svn checkout https://svn.edgewall.org/repos/trac/trunk
C:\Trac>python trac\admin\tests\console.py
SKIP: trac.admin.tests.console.TracAdminComponentTestCase (__name__ is not trac.admin.tests.console)
................................................................E.
======================================================================
ERROR: test_deploy (__main__.TracAdminDeployTestCase)
Deploy into valid target directory.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "trac\admin\tests\console.py", line 849, in tearDown
    shutil.rmtree(self.env.path)
  File "c:\Python27\Lib\shutil.py", line 247, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "c:\Python27\Lib\shutil.py", line 247, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "c:\Python27\Lib\shutil.py", line 247, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "c:\Python27\Lib\shutil.py", line 247, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "c:\Python27\Lib\shutil.py", line 252, in rmtree
    onerror(os.remove, fullname, sys.exc_info())
  File "c:\Python27\Lib\shutil.py", line 250, in rmtree
    os.remove(fullname)
WindowsError: [Error 5] Access is denied: 'c:\\users\\joe\\appdata\\local\\temp\\trac-testdir-gnhitw\\www\\htdocs\\common\\.svn\\all-wcprops'

----------------------------------------------------------------------
Ran 66 tests in 7.113s

FAILED (errors=1)

Should deploy also copy the .svn folders?

It works after upgrading C:\Trac SVN checkout from to SVN 1.8 working copy format, where only C:\Trac\.svn folder exists, not C:\TracSVN\trac\htdocs\.svn.

[anonymous]

#8278 was the same error.

[Jun Omae]

os.remove() doesn't work for read-only files on Windows. I consider we could always use rmtree in trac.tests.compat rather than shutil.rmtree.

• [bb2a1e280/jomae.git] (jomae.git@t12776+1.0)
• [d00d0efa8/jomae.git] (jomae.git@t12776+1.2)
• [5c901d92e/jomae.git] (jomae.git@t12776+trunk)

[Ryan J Ollos]

It might make sense to move rmtree from trac.tests.compat to trac.test. It was moved there in r12247, but when I look now it seems like an odd place to have placed the function.

Should shutil.rmtree in reset_db_and_disk also use rmtree?: tags/trac-1.2.1/trac/test.py@:487#L479​.

[Jun Omae]

Replying to Ryan J Ollos:

It might make sense to move rmtree from trac.tests.compat to trac.test. It was moved there in r12247, but when I look now it seems like an odd place to have placed the function.

I agree.

Should shutil.rmtree in reset_db_and_disk also be replaced with rmtree?: tags/trac-1.2.1/trac/test.py@:487#L479​.

Ah. I missed it.

Revised 3 branches with your suggestions.

[Ryan J Ollos]

Looks good to me. Thanks for fixing location of rmtree.

[Jun Omae]

Thanks for the reviewing. Committed in [15799-15801].

[Ryan J Ollos]

Spotted a few additional imports that needed modifying while rebasing the python3 branch: r15802, r15803.