Issue warning when running sync for non-cached repository

[Ryan J Ollos]

Running sync on a direct-svn type repository:

Resyncing repository history for proj2... 
0 revisions cached.
Done.

We should issue a warning or error that the repository cannot be synced because it's not a cached repository.

[Jun Omae]

Okay about showing a notice to me, however not okay about a warning or error.

repository sync * with non-cached repository would say an error and exits with non-zero? I'm using repository sync <name> command in same hook script for all Trac environments on production and mercurial repository is included. If the exit code would be non-zero, I would have to check whether a repository is cache/non-cache.

[Ryan J Ollos]

Two possible fixes:

1. [67e65e119/rjollos.git]: could be refactored in #12406 when Repository object might have a cached property.
2. [bd03d2e12/rjollos.git]: change API to have sync return the number of revisions cached.

At this point, I prefer (2).

[Ryan J Ollos]

I committed the simpler change that didn't modify the API, to 1.2-stable in r16039, merged to trunk in r16040.

[Ryan J Ollos]

r16039 does not print the message when a single revision is sync'ed.

[Ryan J Ollos]

Proposed changes: [a45b4f38/rjollos.git].

[Ryan J Ollos]

Committed to 1.2-stable in r16446, merged to trunk in r16447.

[pocek@…]

I think this change introduced a regression. Before Trac 1.2.3 it was possible to sync a GitRepository (not GitCachedRepository). This was actually useful with the following config:

[git]
cached_repository = false
persistent_cache = true

and sync_per_request=False.

One can still call changeset added <repos> DUMMY and it will sync the repo, but repository sync was nicer.

[Ryan J Ollos]

Replying to pocek@…:

I think this change introduced a regression. Before Trac 1.2.3 it was possible to sync a GitRepository (not GitCachedRepository).

Syncing a non-cached repository will invalidate the persistent cache: tags/trac-1.2.3/tracopt/versioncontrol/git/git_fs.py@:678-679#L674​. Is that a useful operation on a non-cached repository? Is it needed because the commit tree may change with each changeset?

The old behavior could be restored with the following change:

trac/versioncontrol/admin.py

@@ -139 +139 @@
             if not isinstance(repos, CachedRepository):
                 printout(_("%(reponame)s is not a cached repository.",
                            reponame=pretty_name))
-            elif rev is not None:
+            if rev is not None:
                 repos.sync_changeset(rev)
                 printout(_('%(rev)s resynced on %(reponame)s.', rev=rev,
                            reponame=pretty_name))

[Ryan J Ollos]

This is more complex than I understood, with the sync operation valid for non-cached repositories. I'm going to remove the printed message added in r16039.

The information I was seeking to help users debug is available at debug level logging:

$ trac-admin tracenvs/proj-1.2 repository sync "trac" 9118e08
12:13:19 Trac[env] INFO: -------------------------------- environment startup [Trac 1.2.4.dev0] --------------------------------
[...]
12:13:23 Trac[git_fs] DEBUG: disabled CachedRepository for '/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git'
9118e08 resynced on trac.
Done.

[Ryan J Ollos]

Changes committed in r16957, merged in r16958.

The net effect of the changes in this ticket was a refactoring of VersionControlAdmin._sync.