Ticket comment edits are not passed through the SpamFilter

[Ryan J Ollos]

First mentioned in comment:12:ticket:10909. It looks like changes are passed to the FilterSystem in plugins/1.2/spam-filter/tracspamfilter/adapters.py@:35#L25​.

It looks like we may need to call ITicketManipulators when editing a comment, and then additional modifications to SpamFilter may be needed.

[Dirk Stöcker]

To check spam requires:

• 1 an entry point which has access to the changed information
• 2 the change to throw an exception
• 3 is before the entry into the database
• 4 has access to the "req" request variable.

—

• The ITicketChangeListener seems only to fulfill point 1.
• The ITicketManipulator does not cover that change yet.
• Other solutions could use IRequestFilter, but these need to reimplement core stuff

The same issue exists for the new edit comment functionality.

Probable solution: Add a new ICommentManipulator interface which handles these ticket changes as well as the wiki comment changes, like…

class ICommentManipulator(Interface):
    """Miscellaneous manipulation of comments."""

    def prepare_commentchange(req, fields, actions):
        """Not currently called, but should be provided for future
        compatibility."""

    def validate_commentchange(req, old_comment, new_comment, type):
        """Validate a comment after it's been changed.

type may be "ticket", "wiki".

[Ryan J Ollos]

⇒ #12725.

[Ryan J Ollos]

Fixed in r15932. Trac r15743 (1.3.2dev) or later is required.