Edgewall Software

Opened 5 years ago

Closed 5 years ago

#12716 closed enhancement (fixed)

Improve wiki edit comment function

Reported by: Dirk Stöcker Owned by: Ryan J Ollos
Priority: normal Milestone: 1.3.3
Component: wiki system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Added comment edit link to wiki diff view.

API Changes:
Internal Changes:


Trac 1.2 has a very cool new feature to edit a wiki comment.

E.g. here you can click and edit the comment: https://josm.openstreetmap.de/wiki/WikiStart?action=history That's fine to fix typos.

When you want to add missing comments you need to see the diff to previous version. It would be extremely helpful, when the diff page https://josm.openstreetmap.de/wiki/WikiStart?action=diff&version=275 also would have an edit comment link.

Attachments (1)

Screen Shot 2017-08-02 at 23.07.22.png (34.0 KB ) - added by Ryan J Ollos 5 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by Ryan J Ollos, 5 years ago

Milestone: next-stable-1.2.x

This is a good idea.

comment:2 by Peter Suter, 5 years ago

The mockup from comment:31:ticket:6573 seems similar.

comment:3 by Ryan J Ollos, 5 years ago

Milestone: next-stable-1.2.x1.3.3
Owner: set to Ryan J Ollos
Release Notes: modified (diff)
Status: newassigned

by Ryan J Ollos, 5 years ago

comment:4 by Ryan J Ollos, 5 years ago

Since comment is input as a oneliner (via an input rather than textarea), I'm thinking we can simply have a link to the wiki comment edit page. Eventually I think we could switch to in-place editing in fields like this (#11466).

I've prepared some changes in [b44dcf894/rjollos.git].

  1. Is there a better way to redirect back to the originating page rather than passing around the referrer argument?
  2. Is there a better idea on how to position or style the Edit button?
Last edited 5 years ago by Ryan J Ollos (previous) (diff)

comment:5 by Ryan J Ollos, 5 years ago

Proposed changes in [7be43ad1e/rjollos.git].

comment:6 by Ryan J Ollos, 5 years ago

Resolution: fixed
Status: assignedclosed

Committed to trunk in r16362.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.