Opened 8 years ago
Closed 7 years ago
#12716 closed enhancement (fixed)
Improve wiki edit comment function
| Reported by: | Dirk Stöcker | Owned by: | Ryan J Ollos |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.3.3 |
| Component: | wiki system | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: |
Added comment edit link to wiki diff view. |
||
| API Changes: | |||
| Internal Changes: | |||
Description
Trac 1.2 has a very cool new feature to edit a wiki comment.
E.g. here you can click and edit the comment: https://josm.openstreetmap.de/wiki/WikiStart?action=history That's fine to fix typos.
When you want to add missing comments you need to see the diff to previous version. It would be extremely helpful, when the diff page https://josm.openstreetmap.de/wiki/WikiStart?action=diff&version=275 also would have an edit comment link.
Attachments (1)
Change History (7)
comment:1 by , 8 years ago
| Milestone: | → next-stable-1.2.x |
|---|
comment:3 by , 7 years ago
| Milestone: | next-stable-1.2.x → 1.3.3 |
|---|---|
| Owner: | set to |
| Release Notes: | modified (diff) |
| Status: | new → assigned |
by , 7 years ago
| Attachment: | Screen Shot 2017-08-02 at 23.07.22.png added |
|---|
comment:4 by , 7 years ago
Since comment is input as a oneliner (via an input rather than textarea), I'm thinking we can simply have a link to the wiki comment edit page. Eventually I think we could switch to in-place editing in fields like this (#11466).
I've prepared some changes in [b44dcf894/rjollos.git].
- Is there a better way to redirect back to the originating page rather than passing around the
referrerargument? - Is there a better idea on how to position or style the Edit button?
comment:6 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Committed to trunk in r16362.
This is a good idea.