Opened 7 years ago
Closed 7 years ago
#12709 closed defect (fixed)
Unable to edit/delete report with no SQL query — at Version 4
| Reported by: | Jun Omae | Owned by: | Jun Omae |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.2.1 |
| Component: | report system | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: |
Buttons in report view are available even when no query. |
||
| API Changes: | |||
| Internal Changes: | |||
Description
When report with no SQL query is shown, TracError is raised. However, edit and delete buttons are unavailable. The error couldn't be solved.
We should show the buttons when error is raised.
Change History (4)
comment:1 by , 7 years ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
comment:2 by , 7 years ago
Changes look good. On trunk _insert_report was added to ReportModuleTestCase in r15599. The method could be added on 1.2-stable and used to simplify test cases slightly. Also self.assertEqual(True ⇒ self.assertTrue( replacements could be made.
comment:3 by , 7 years ago
Thanks for the reviewing!
Okay. In this case we could use self.assertTrue.
comment:4 by , 7 years ago
| Release Notes: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
Proposed changes in [06ad22c27/jomae.git] (jomae.git@t12709).