Edgewall Software

Opened 6 years ago

Last modified 6 years ago

#12691 closed defect

Reduce error level for invalid session id — at Version 3

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2.1
Component: web frontend Version:
Severity: normal Keywords: session
Cc: Branch:
Release Notes:

Reduce logging level from error to warning for TracError: Session ID must be alphanumeric.

API Changes:

Added TracValueError exception.

Internal Changes:

Description (last modified by Ryan J Ollos)

I see these errors in the logs rather frequently:

2017-02-16 18:00:27,670 Trac[main] ERROR: can't retrieve session: TracError: Session ID must be alphanumeric.

I think we could change the log level to warning: tags/trac-1.2/trac/web/main.py@:352#L348. Error implies some abnormal behavior that needs attention, whereas this is just a case of invalid input.

Change History (3)

comment:1 by Ryan J Ollos, 6 years ago

Description: modified (diff)
Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to 1.2-stable in r15538, merged to trunk in r15539.

comment:2 by Ryan J Ollos, 6 years ago

Resolution: fixed
Status: closedreopened

This was shortsighted. The test failure demonstrates that there are situations in which we may want to log an error. Maybe we should raise an InvalidSessionId exception and log that at warning level, with other TracErrors logged at error level?

comment:3 by Ryan J Ollos, 6 years ago

API Changes: modified (diff)
Last edited 6 years ago by Ryan J Ollos (previous) (diff)
Note: See TracTickets for help on using tickets.