Add "View blame prior to this change" link to blame view

[anonymous]

Blame view (example​) seems to be missing this very useful feature available on github (​example).

On github each blame annotation line has a small icon with tooltip "View blame prior to this change" that links to the same blame page but at an older revision. This is allows quickly navigating through the history of the file.

[Christian Boos]

It's there but it's kind of a "hidden feature".

If you click on a revision in the left column, the corresponding changeset shows up. There, any revision link will lead you to the blame view restarting at that revision, including the barely visible "…" link between each chunk.

Suggestions about how to make this better welcome.

[anonymous]

If you click on a revision in the left column, the corresponding changeset shows up.

Yes, I was already aware of this, but did not find this feature there. (And I looked many times there before.)

There, any revision link will lead you to the blame view restarting at that revision,

Huh? I only see one revision link: the big title ("Changeset 9492") and it does not do that. That revision would not be useful anyway, but the one before.

including the barely visible "…" link between each chunk.

Huh? Oh. Even when knowing to look for "…" I didn't see that forever. Hidden feature indeed. Thanks.

Suggestions about how to make this better welcome.

How about a big button next to the "close" button, that says "Blame previous"?

[anonymous]

Mockup of "Blame Previous" button

[Ryan J Ollos]

Replying to anonymous:

Huh? I only see one revision link: the big title ("Changeset 9492") and it does not do that. That revision would not be useful anyway, but the one before.

including the barely visible "…" link between each chunk.

Huh? Oh. Even when knowing to look for "…" I didn't see that forever. Hidden feature indeed. Thanks.

I'm still not seeing the "…". Any further hints?

Suggestions about how to make this better welcome.

How about a big button next to the "close" button, that says "Blame previous"?

That looks reasonable.

[Christian Boos]

focus on the …

[Christian Boos]

Between the hunks…

I still think it's useful there as it leads back to these lines in the next (well, previous) annotate view, but it should be given more visibility, like a (Blame) button instead of the nearly invisible "…" link.

The (Blame previous) button near the close is a good idea as well.

[anonymous]

trac/htdocs/js/blame.js

@@ -79 +79 @@
             // remove former message panel if any
             if (message)
               message.remove();
+
+            var previous_link = $(data).find('.trac-diff a').first();
+            var previous_button = $('<input value="' + _("Blame Previous") + '" type="button">');
+            if (previous_link.length) {
+                function previous() {
+                  /* Go to previous changeset */
+                  window.location.href = previous_link.attr('href');
+                }
+                previous_button.click(previous);
+            } else {
+                previous_button.attr("disabled","disabled");
+            }
             // create new message panel
             if (!data)
               data = "<strong>" + _("(no changeset information)") + "</strong>";
             message = $('<div class="message">').css("position", "absolute")
                 .append($('<div class="inlinebuttons">')
+                  .append(previous_button)
                   .append($('<input value="' + _("Close") + '" type="button">').click(hide)))
                 .append($('<div class="embedded">').html(data))
               .appendTo("body");

I'm out of ideas for how to fix the #L fragment to link to the clicked line number.

[Ryan J Ollos]

Milestone renamed