/milestone only redirects to /roadmap if user has MILESTONE_VIEW

[Ryan J Ollos]

If user has MILESTONE_VIEW /milestone redirects to /roadmap. A PermissionError is displayed if user doesn't have MILESTONE_VIEW.

We could make the behavior consistent by always redirecting to /roadmap with a patch such as:

trac/ticket/roadmap.py

@@ -736 +736 @@
 
     def process_request(self, req):
         milestone_id = req.args.get('id')
+        if not milestone_id:
+            req.redirect(req.href.roadmap())
         req.perm(self.realm, milestone_id).require('MILESTONE_VIEW')
 
         add_link(req, 'up', req.href.roadmap(), _("Roadmap"))
@@ -767 +769 @@
         elif action == 'delete':
             return self._render_confirm(req, milestone)
 
-        if not milestone.name:
-            req.redirect(req.href.roadmap())
-
         return self._render_view(req, milestone)
 
     # Public methods

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t12666_milestone_redirect_to_roadmap.