Opened 7 years ago
Last modified 7 years ago
#12666 closed defect
/milestone only redirects to /roadmap if user has MILESTONE_VIEW — at Initial Version
Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Milestone: | 1.3.2 |
Component: | roadmap | Version: | |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
If user has MILESTONE_VIEW
/milestone
redirects to /roadmap
. A PermissionError
is displayed if user doesn't have MILESTONE_VIEW
.
We could make the behavior consistent by always redirecting to /roadmap
with a patch such as:
-
trac/ticket/roadmap.py
diff --git a/trac/ticket/roadmap.py b/trac/ticket/roadmap.py index d1328a4c3..c5c8952d1 100644
a b class MilestoneModule(Component): 736 736 737 737 def process_request(self, req): 738 738 milestone_id = req.args.get('id') 739 if not milestone_id: 740 req.redirect(req.href.roadmap()) 739 741 req.perm(self.realm, milestone_id).require('MILESTONE_VIEW') 740 742 741 743 add_link(req, 'up', req.href.roadmap(), _("Roadmap")) … … class MilestoneModule(Component): 767 769 elif action == 'delete': 768 770 return self._render_confirm(req, milestone) 769 771 770 if not milestone.name:771 req.redirect(req.href.roadmap())772 773 772 return self._render_view(req, milestone) 774 773 775 774 # Public methods
Note:
See TracTickets
for help on using tickets.